Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: Fix wild card handling #499

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Commits on Aug 22, 2024

  1. rules: Fix wild card handling

    The handling of wild card `*` is different in libxkbfile and X server:
    wild card matches empty strings for model and option but not for layout
    nor variant, while in libxkbcommon wild cards always match empty strings.
    
    See:
    - https://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/blob/bf985c68acb1244f51ec91414532a2347fbc1c4c/src/maprules.c#L687
    - https://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/blob/bf985c68acb1244f51ec91414532a2347fbc1c4c/src/maprules.c#L712
    
    The difference of handling between the components is unfortunately not
    documented, but we should follow the behavior of the original
    implementations for consistency.
    
    - Fixed by implementing the same behavior than libxkbfile.
    - Added tests and fixed failing tests.
    - Improve the documentation of rules to highlight the special behavior.
    wismill committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6238f69 View commit details
    Browse the repository at this point in the history