Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve CI setup #469

Merged
merged 3 commits into from
Mar 13, 2024
Merged

improve CI setup #469

merged 3 commits into from
Mar 13, 2024

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Mar 12, 2024 •
edited
Loading

  • use py3.12 for ci
  • bump action dependencies

cc @wismill

@chenrui333 chenrui333 marked this pull request as ready for review March 12, 2024 14:29
@chenrui333 chenrui333 force-pushed the mac-ci branch 2 times, most recently from bbf1c33 to a9a6d15 Compare March 12, 2024 15:03
@chenrui333 chenrui333 mentioned this pull request Mar 12, 2024
Merged
whot
whot approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, see my pip vs brew question though please, thanks.

.github/workflows/macos.yml Outdated Show resolved Hide resolved
.github/workflows/macos.yml Show resolved Hide resolved
@wismill wismill added the ci Continuous integration label Mar 13, 2024
@chenrui333 chenrui333 requested review from wismill and whot March 13, 2024 13:44
@chenrui333 @wismill
ci: Use Python 3.12
cbbe87f 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 @wismill
ci: Bump action deps to use nodejs 20 runtime
9ec1f5e 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 @wismill
ci(macOS): Use brew for all deps and remove doc deps
f4fd98e 
Install meson and pyyaml via brew, as this the standard way on macOS.

Remove Doxygen and Graphviz dependencies, as we do not build
documentation by default anymore.

Signed-off-by: Rui Chen <[email protected]>
wismill
wismill approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@wismill wismill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and squashed some commits

@wismill wismill merged commit 346d687 into xkbcommon:master Mar 13, 2024
4 checks passed
@wismill
Copy link
Member

wismill commented Mar 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wismill wismill wismill approved these changes

@whot whot Awaiting requested review from whot

Assignees
No one assigned
Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @wismill @whot