Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.7.0 #445

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Prepare for 1.7.0 #445

merged 1 commit into from
Mar 23, 2024

Conversation

wismill
Copy link
Member

@wismill wismill commented Feb 8, 2024

I think we are ready for a new release. There are a few MRs ( #391, #415, #434, #440) that would make a release worth on their own.

Updated NEWS.

TODO:

  • Merge remaining MR planned for 1.7.0

Few questions:

  • Is the changelog too detailed?
  • Should the keysyms update goes to “breaking changes”? I consider it more as a fix, but it does break anything that rely on the reverted canonical names.

@wismill wismill requested review from bluetech and whot February 8, 2024 08:31
@whot
Copy link
Contributor

whot commented Feb 8, 2024

I'm leaving this here because it's related: input-leap which I've worked on in the past uses towncrier to generate the release notes. May be worth looking at for the next release because it detaches writing the release notes for each addition from the actual release process.

edit: there are lots of other projects that do the same I expect, towncrier is just the one I've come across

@wismill
Copy link
Member Author

wismill commented Feb 8, 2024

@whot I think this is a really good idea. It is much easier to write the entries for news at the time of the MR. And having the NEWS generated for us is less pain.

I have seen other tools like this in other projects too. Since xkbcommon is not a big project, we do not need a very advanced tool. I’ll give a look some later.

@wismill wismill added this to the 1.7.0 milestone Feb 8, 2024
Copy link
Contributor

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks, but I leave the final ack to @bluetech

NEWS Outdated Show resolved Hide resolved
@wismill
Copy link
Member Author

wismill commented Feb 11, 2024

@whot suggested that we should downgrade parse error on Mod6-Mod32 to mere warning ASAP, in preparation of future addition to real modifiers. See #447 for a PoC and discussion.

@whot
Copy link
Contributor

whot commented Feb 13, 2024

fwiw, given how #447 is going to be a bit more complex I reckon it might be best punting that to the next release.

@bluetech
Copy link
Member

bluetech commented Mar 1, 2024

Is the changelog too detailed?

I think it's good!

Should the keysyms update goes to “breaking changes”? I consider it more as a fix, but it does break anything that rely on the reverted canonical names.

I think the current changelog makes things pretty clear.

@wismill wismill force-pushed the release/1.7.0 branch 3 times, most recently from ba74b38 to bcd9ede Compare March 1, 2024 15:31
@wismill
Copy link
Member Author

wismill commented Mar 7, 2024

@whot @bluetech only #465 remains for this release.

@wismill
Copy link
Member Author

wismill commented Mar 7, 2024

Note: Release notes should be updated if #465 is merged.

I am testing towncrier as proposed by Peter. Sounds a good tool for the job, will send MR soon for the next release.

@wismill
Copy link
Member Author

wismill commented Mar 7, 2024

I added entry for #465. Please check my wording: my intention is to warn of the inconsistency but at the same time to reassure it was an issue with relatively only few keysyms.

@wismill
Copy link
Member Author

wismill commented Mar 15, 2024

Added entry for #468 (pending).

@wismill wismill marked this pull request as ready for review March 22, 2024 15:13
@wismill wismill requested a review from whot March 22, 2024 15:13
@wismill
Copy link
Member Author

wismill commented Mar 22, 2024

@bluetech @whot I think we are ready for a new release. The NEWS.md file requires a proper date.

@whot
Copy link
Contributor

whot commented Mar 23, 2024

LGTM!

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added an entry for d455e80, will do the release now.

@bluetech bluetech merged commit 9e2c3b7 into xkbcommon:master Mar 23, 2024
4 checks passed
@wismill wismill deleted the release/1.7.0 branch July 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants