Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Use a xvfb wrapper for x11 test #348

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Test: Use a xvfb wrapper for x11 test #348

merged 4 commits into from
Sep 18, 2023

Commits on Sep 18, 2023

  1. Test: Use a xvfb wrapper for x11 test 

    The x11 test is currently silently skipped in CI, because it requires a
running X server.

Create a xvfb wrapper to run the test. We do not use `xvfb-run`, because
it is a shell script and it causes valgrind to detect unrelated memory
issues in the shell (dash, bash).

Improve wrapper using a special ELF section

TODO: The wrapper is intended to be used with the x11comp test as well.
    @wismill
    wismill committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1be4489 View commit details
    Browse the repository at this point in the history

  2. Test: Catch SIGUSR1 from Xvfb for X11 tests 

    Based on the work done by Peter Hutterer. Original commit message:

If SIGUSR1 is set to SIG_IGN, X servers (all of them, including Xvfb)
will send that signal to the parent process when they're ready to accept
connections. We can use that instead of a hardcoded sleep which brings
the wait down to ~37ms on my box.
    @wismill
    wismill committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    8dd5d1b View commit details
    Browse the repository at this point in the history

  3. Test: Enable x11comp and use the xvfb wrapper 

    This test was previously disabled in 914e84e.

Note that it requires a recent version of xkeyboard-config to succeed.
    @wismill
    wismill committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ec09c3e View commit details
    Browse the repository at this point in the history

  4. CI: Use git master for xkeyboard-config on Linux 

    xkeyboard-config and xkbcommon projects are quite intertwined so we
want things to blow up early.

It also solves an issue with the x11comp test.
    @wismill
    wismill committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    76b3799 View commit details
    Browse the repository at this point in the history