forked from projectceladon/device-androidia
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set permissive #5
Open
xihua-chen
wants to merge
62
commits into
master
Choose a base branch
from
mynew
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 20, 2020
-
Tracked-On: OAM-86904 Signed-off-by: bodapati <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2f0f07 - Browse repository at this point
Copy the full SHA f2f0f07View commit details -
Refine x86 options to support more platforms Change cpu-arch to x86 option Tracked-On: OAM-86904 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#417 Mixin-Reviewed-On: projectceladon#591 Signed-off-by: bodapati <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f4ea8a - Browse repository at this point
Copy the full SHA 6f4ea8aView commit details -
[postinstall] Fix "fails to run postinstall" issue 1. Sepolicy path of postinstall was changed, modify BOARD_SEPOLICY_DIRS to point to right path. 2. Use system/bin/sh to replace vendor/bin/sh Android Q add support using system/bin/sh in recovery mode Tracked-On: OAM-86848 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#412 Signed-off-by: Heng Luo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c2bc617 - Browse repository at this point
Copy the full SHA c2bc617View commit details -
Set overlay for disabling keepalive offload to address CTS issue Keepalive packet offloading is enabled by default. CTS test cases are failing as the keepalive offloading event is not received. As keepalive offloading is not supported, override the configs to disable it to address CTS failures. Tracked-On: OAM-86930 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#418 Signed-off-by: Aiswarya Cyriac <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 404a6ce - Browse repository at this point
Copy the full SHA 404a6ceView commit details -
Tracked-On: OAM-86757 Signed-off-by: sunxunou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1aa7577 - Browse repository at this point
Copy the full SHA 1aa7577View commit details -
Support kernelflinger-for-cic.efi build for cic Add boot-arch groups for cic Tracked-On: OAM-86757 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#402 Mixin-Reviewed-On: projectceladon#570 Signed-off-by: sunxunou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 43110b9 - Browse repository at this point
Copy the full SHA 43110b9View commit details -
Rename build result file as CI convention. We have certain logic in our CI process that depends on this naming convention for the build result: lunchtargetname-buildnumber Otherwise, it will break the CI process. Tracked-On: OAM-88183 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#423 Signed-off-by: zhongjie <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59d95d0 - Browse repository at this point
Copy the full SHA 59d95d0View commit details -
Simplify the preparation work of setting VM 1. install UEFI from package source. 2. use emulational USB to optimize the flash process. 3. automatize flash process, user could flash without operations in UEFI. Tracked-On: OAM-88180 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#425 Signed-off-by: Liu, Xinwu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e8d094 - Browse repository at this point
Copy the full SHA 0e8d094View commit details -
Remove cp_ss This module is only required for the OTA across pre-P to P or successors. No requirement of O->Q now. And it will cause to ATS failure due to sepolicy. Tracked-On: OAM-86820 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#408 Signed-off-by: Huang Yang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 34ca465 - Browse repository at this point
Copy the full SHA 34ca465View commit details -
Donot load VM when host kernel version lower than V5.0.0 Caas VM is working on host kernel newer than V5.0.0 with trusty enabled. Tracked-On: OAM-88232 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#429 Signed-off-by: Liu, Xinwu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bce5ba9 - Browse repository at this point
Copy the full SHA bce5ba9View commit details -
Tracked-On: OAM-86881 Signed-off-by: Fei Jiang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff7884a - Browse repository at this point
Copy the full SHA ff7884aView commit details -
EM: Update power profile "cpu.core_power.cluster0" is a new power profile domain and used to caculate cpu power usage by BatteryStatsHelper.java. This patch adds this power profile for GP IVI. NOTE: the current values are fake data as no real battery in GP MRB. Tracked-On: OAM-86942 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#430 Signed-off-by: Sun Xinx <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f0cb0f - Browse repository at this point
Copy the full SHA 9f0cb0fView commit details -
x86: config: Enable support for RTL8152 dongle This patch adds support for RTL8152 USB ethernet dongle for Android platforms. This is an Android compliance requirement. Tracked-On: OAM-88225 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#434 Signed-off-by: saranya <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 008dc16 - Browse repository at this point
Copy the full SHA 008dc16View commit details -
Rebasing kernel tag to 4.19.78 Tracked-On: OAM-88281 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#435 Signed-off-by: rnaidu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f815f2c - Browse repository at this point
Copy the full SHA f815f2cView commit details -
Set usb-ota-switch to true. Tracked-On: OAM-88331 Signed-off-by: sarora2x <[email protected]> Signed-off-by: M Balaji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9333cf - Browse repository at this point
Copy the full SHA c9333cfView commit details -
Fix for ADB over usb. Set usb-ota-switch to true. Tracked-On: OAM-88331 Mixin-Reviewed-On: projectceladon#616 Signed-off-by: M Balaji <[email protected]> Signed-off-by: sarora2x <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 910898b - Browse repository at this point
Copy the full SHA 910898bView commit details -
Bluetooth and WLAN mixin changes to adopt aaf
Bluetooth and WLAN mixin changed to auto. Tracked-On: OAM-88286 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]> Signed-off-by: Aiswarya Cyriac <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2d08b6 - Browse repository at this point
Copy the full SHA d2d08b6View commit details -
Bluetooth and WLAN mixin changes to adopt aaf Changes done: - Enabled new mixin group auto for bluetooth and wlan - Added generic libraries and packages neeed for bluetooth and wlan to support multiple connectivity modules. - Bluetooth profiles updated to match tablet device type - Set property persist.bluetooth.enablenewavrcpto true to get BT A2DP, AVRCP working. - Based on detected bluetooth chip set vendor property vendor.bluetooth.chip. Bluetooth and WLAN mixin changes to adopt aaf Bluetooth and WLAN mixin changed to auto. Tracked-On: OAM-88286 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#436 Mixin-Reviewed-On: projectceladon#615 Signed-off-by: Aiswarya Cyriac <[email protected]> Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 84b1d86 - Browse repository at this point
Copy the full SHA 84b1d86View commit details -
Change target-level to 4 for Q Tracked-On: OAM-85223 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#415 Signed-off-by: Qiming Shi <[email protected]> Signed-off-by: Tong Bo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 464b625 - Browse repository at this point
Copy the full SHA 464b625View commit details -
Set control_privapp_permissions to enforce New cts cases of Q require control_privapp_permissions must be enforce. Test: run cts -m CtsPermission2TestCases -t android.permission2.cts.PrivappPermissionsTest#privappPermissionsMustBeEnforced Tracked-On: OAM-86934 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#427 Signed-off-by: Xie, Shellyx <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b3d2657 - Browse repository at this point
Copy the full SHA b3d2657View commit details -
media_profiles.xml: Make changes to pass CTS CamcorderProfileTest expects "high" profile to match with max profile in each category. This patch adds changes for that. This was tested with Logitech 1080p camera which is POR for camera team. Tracked-On: OAM-86962 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#437 Signed-off-by: saranya <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd78c32 - Browse repository at this point
Copy the full SHA dd78c32View commit details -
CIV: Enable virtual VT-d(vIOMMU) Add options in start_android_qcow2.sh: -device intel-iommu,device-iotlb=off \ The "device-iotlb" must off due to a QEMU issue: https://patchew.org/QEMU/[email protected]/ Tracked-On: OAM-88511 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#439 Signed-off-by: Qi Yadong <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4146eaa - Browse repository at this point
Copy the full SHA 4146eaaView commit details -
Set file_encryption to true Tracked-On: OAM-88514 Signed-off-by: Ai, Ting A <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ccba4a1 - Browse repository at this point
Copy the full SHA ccba4a1View commit details -
Enable FBE for CIV Set file_encryption to true Tracked-On: OAM-88514 Mixin-Reviewed-On: projectceladon#627 Signed-off-by: Ai, Ting A <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3914e10 - Browse repository at this point
Copy the full SHA 3914e10View commit details -
CIV: Enable virtual VT-d(vIOMMU) for launch_swrender() The launch script may fall-back to launch_swrender(). When launch with sw rendering, the vIOMMU is also required. Tracked-On: OAM-88532 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#442 Signed-off-by: Qi Yadong <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c128041 - Browse repository at this point
Copy the full SHA c128041View commit details -
Fix some treble violations There are some operations violate the treble requiements, and this introduces some selinux avc errors that cannot be fixed. Fix these violations so we can add proper sepolicy rules for this. Tracked-On: OAM-88545 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#444 Signed-off-by: ji, zhenlong z <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54f4292 - Browse repository at this point
Copy the full SHA 54f4292View commit details -
[BT] Add BT usb vendor ID and product ID As part of BT enablement, added vendor and product id to usb-host on boot time. Tracked-On: OAM-88567 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#448 Signed-off-by: Raveendra Babu Chennakesavulu
Configuration menu - View commit details
-
Copy full SHA for 4ba98f2 - Browse repository at this point
Copy the full SHA 4ba98f2View commit details -
Tracked-On: OAM-88583 Signed-off-by: ji, zhenlong z <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a0a566 - Browse repository at this point
Copy the full SHA 8a0a566View commit details -
Enable selinux for caas Tracked-On: OAM-88583 Mixin-Reviewed-On: projectceladon#635 Signed-off-by: ji, zhenlong z <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 997d925 - Browse repository at this point
Copy the full SHA 997d925View commit details -
Enable usb camera in VM Assigned logitech 1080p(C922, C920) USB devices to VM Tracked-On: OAM-88591 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#449 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9d2028 - Browse repository at this point
Copy the full SHA c9d2028View commit details -
[CIV] Enable USB based Touch devices Added eGalax7200, GeChic and ELO touch devices as a passthrough devices for VM. Tracked-On: OAM-88602 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#451 Signed-off-by: Jaikrishna Nemallapudi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 77ac54b - Browse repository at this point
Copy the full SHA 77ac54bView commit details -
caas: Set media profile name in codecs mixins to support 1080p
Set media profiles file name to media_profiles_1080p.xml to support 720p and 1080p video recording. Tracked-On: OAM-88630 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5490b2 - Browse repository at this point
Copy the full SHA d5490b2View commit details -
Camera: Add support for 4k@30,HD/FHD@60 resolution Adding support for 4k UHD@30, 4k DCI@30fps, 1080p@60, 720p@60 resolutions. All 4k@30 or FHD/HD@60 fps cameras are supported through USB 3.x standard. caas: Change order of usb host device pass through Camera not working properly after touch screen devices are passed to VM. Fix the issue by moving the USB camera pass through to top of the list. caas: Set media profile name in codecs mixins to support 1080p Set media profiles file name to media_profiles_1080p.xml to support 720p and 1080p video recording. Tracked-On: OAM-88590 Tracked-On: OAM-88630 Tracked-On: OAM-88637 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#450 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#453 Mixin-Reviewed-On: projectceladon#644 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]> Signed-off-by: Muhammad Aksar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d1e6f1 - Browse repository at this point
Copy the full SHA 4d1e6f1View commit details -
Enable Virgl(Virtual 3D GPU) This changes help to support Virgl(Virtual 3D GPU) for guest virtual machines. Tracked-On: OAM-88714 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#454 Signed-off-by: Jin, Zhi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a0692b - Browse repository at this point
Copy the full SHA 3a0692bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2086724 - Browse repository at this point
Copy the full SHA 2086724View commit details -
Enable Opensource MediaSDK OpenMAX plugin mixin updates for mediasdk_omx_il Tracked-On: OAM-88548 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#446 Mixin-Reviewed-On: projectceladon#632
Configuration menu - View commit details
-
Copy full SHA for a9dd34b - Browse repository at this point
Copy the full SHA a9dd34bView commit details -
CIV: check nested VT in launch script Check nested VT status before launch Guest OS. If nested VT is not enabled, exit script with error hint. Tracked-On: OAM-88755 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#460 Signed-off-by: Qi Yadong <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 19676a6 - Browse repository at this point
Copy the full SHA 19676a6View commit details -
Update script to avoid audio stuttering and correct audio pace Tracked-On: OAM-88716 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#466 Signed-off-by: padmashree9110 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f753d1 - Browse repository at this point
Copy the full SHA 7f753d1View commit details -
kernel rebase to 4.19.87 for caas Tracked-On: OAM-88793 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#467 Signed-off-by: rnaidu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5b520cc - Browse repository at this point
Copy the full SHA 5b520ccView commit details -
Adding the changes to support cvt 4k display Tracked-On: OAM-88790 Signed-off-by: rbabub <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5a9d2ab - Browse repository at this point
Copy the full SHA 5a9d2abView commit details -
[CIV] Enable 4k Touch device Adding the changes to support cvt 4k display [CIV] Enable 4k Touch device Adding the changes to support cvt 4k display Tracked-On: OAM-88790 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#470 Mixin-Reviewed-On: projectceladon#665 Signed-off-by: rbabub <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8506a4e - Browse repository at this point
Copy the full SHA 8506a4eView commit details -
Enable "full-screen" in launching qemu For Android UI is booting with Full Screen, add an option in QEMU launching. For switching back to host from Androud Full screen, "Ctrl-Alt-F" can be used. Tracked-On: OAM-88724 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#471 Signed-off-by: Shaofeng Tang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 045a342 - Browse repository at this point
Copy the full SHA 045a342View commit details -
CIV: enable ramfb enable ramfb to support boot display. ramfb is a very simple framebuffer display device. It is intended to be configured by the firmware and used as boot framebuffer, until the guest OS loads a real GPU driver. Tracked-On: OAM-88855 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#469 Signed-off-by: JianFeng,Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ecfeeb8 - Browse repository at this point
Copy the full SHA ecfeeb8View commit details -
CIV: fix QEMU 4.2 build error QEMU 4.2 depends on libsdl2-dev. install libsdl2-dev before building QEMU 4.2 Tracked-On: OAM-89033 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#480 Signed-off-by: JianFeng,Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2429a13 - Browse repository at this point
Copy the full SHA 2429a13View commit details -
Trusty: Use pre-built Trusty release binary to build tos image Tracked-On: OAM-88999 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#478 Signed-off-by: Zhong,Fangjian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b5a68c2 - Browse repository at this point
Copy the full SHA b5a68c2View commit details -
Use PulseAudio as Audio backend with config change QEMU has default timer-period set to 10 milliseconds. This is quite long for PulseAudio, which causes audio distortion. It is solved by reducing timer-period to 5 milliseconds. Tested Audio playback/capture. Tracked-On: OAM-89014 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#485 Signed-off-by: Prashanth M, Shakthi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6ac96d5 - Browse repository at this point
Copy the full SHA 6ac96d5View commit details -
Add PulseAudio as backend at build time QEMU audio backend needs to be configured at build time. This commit adds PulseAudio as backedn at build time. Tracked-On: OAM-89307 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#486 Signed-off-by: Prashanth M, Shakthi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4187edc - Browse repository at this point
Copy the full SHA 4187edcView commit details -
Rebasing the kernel to 4.19.94 on caas Tracked-On: OAM-89587 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#487 Signed-off-by: rnaidu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c35fd76 - Browse repository at this point
Copy the full SHA c35fd76View commit details -
change Vsync offset of app and SurfaceFlinger to improve performance …
…on 4K Tracked-On: OAM-88781
Configuration menu - View commit details
-
Copy full SHA for dc926af - Browse repository at this point
Copy the full SHA dc926afView commit details -
[CELADON] Issue resolved when the image file is large Tracked-On: OAM-89658 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#497 Signed-off-by: swaroopb <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7df3eb8 - Browse repository at this point
Copy the full SHA 7df3eb8View commit details -
Update scripts for automation Launch kvmgt module before start QEMU on host linux kernel higher than 5.3.0, kvmgt not launched by default. need to launch kvmgt module before start QEMU. otherwise, VGPU can't be created and android UI will not be shown. Tracked-On: OAM-89684 Tracked-On:OAM-89705 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#499 Mixin-Reviewed-On: projectceladon/device-androidia-mixins#500 Signed-off-by: JianFeng,Zhou <[email protected]> Signed-off-by: padmashree9110 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3e4af34 - Browse repository at this point
Copy the full SHA 3e4af34View commit details -
Tracked-On: Signed-off-by: Xihua Chen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9c6c83f - Browse repository at this point
Copy the full SHA 9c6c83fView commit details
Commits on Feb 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 66a06d8 - Browse repository at this point
Copy the full SHA 66a06d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 678273f - Browse repository at this point
Copy the full SHA 678273fView commit details -
Configuration menu - View commit details
-
Copy full SHA for df53f96 - Browse repository at this point
Copy the full SHA df53f96View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa613bb - Browse repository at this point
Copy the full SHA aa613bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef119c1 - Browse repository at this point
Copy the full SHA ef119c1View commit details
Commits on Mar 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 966a9d7 - Browse repository at this point
Copy the full SHA 966a9d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 709c73a - Browse repository at this point
Copy the full SHA 709c73aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d52499 - Browse repository at this point
Copy the full SHA 0d52499View commit details
Commits on Mar 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c77598d - Browse repository at this point
Copy the full SHA c77598dView commit details
Commits on Mar 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4cf03dc - Browse repository at this point
Copy the full SHA 4cf03dcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.