Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation strings for the dropdown list items #1530

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Add translation strings for the dropdown list items #1530

wants to merge 18 commits into from

Conversation

dagonix
Copy link
Contributor

@dagonix dagonix commented Jan 2, 2023

No description provided.

ifarzana and others added 18 commits December 13, 2022 16:53
@ifarzana
Connector Reports
d5a99f1
@ifarzana
Connector Reports: List reports of the connector xibosignage/xibo#2959
c443303
@ifarzana
api key in audience connector form
71bb41b
@ifarzana
Review fix
290bb38
@ifarzana
Review fix
42ec0b6
@ifarzana
Tweak
c72adaf
@ifarzana
Add the Campaign column in the Saved Report xibosignage/xibo#2965
1e820b7
@ifarzana
Review reports and add reports for connector
2346357
@dasgarner
Merge pull request xibosignage#1520 from ifarzana/campaignPop
47928b7 
Connector Reports
@ifarzana
Mobile Proof of play
38dea35
@ifarzana
Display Ad play
040cf2e
@ifarzana
Tweak
7e4c53e
@dasgarner
Merge pull request xibosignage#1523 from ifarzana/campaignPop
2156c6a 
Connector reports: Mobile POP and Display Ad Play
@ifarzana
Connector: Audience Reporting - fix for sending non ad campaign stats (…
d63637b 
…xibosignage#1524)

Work towards: xibosignageltd/xibo-private#85
* Receive Stat takes only ad campaign stats
* Workflows : update ubuntu version to 22.04
@dasgarner
Connector: Audience connector DMA forms (xibosignage#1525)
023a373 
Build out the audience connector DMA feature with search/add/edit/delete functionality. Ready for testing.
xibosignageltd/xibo-private#85
@ifarzana
Connector: Add Display Played Percentage Report (xibosignage#1529)
22493f9 
* Receive Stats and Display Percentage Connector Report
@dasgarner
Ad Campaigns: adjust scheduler for xibosignage/xibo#2971 (xibosignage…
2794da6 
…#1528)

* Ad Campaigns: adjust scheduler so that it:
 - stops scheduling when we reach 100% of target
 - stops scheduling when progress to target is 5% over
 - splits plays needed by the number of logged in/valid displays in the schedule
 - adjusts budget/impression targets based on logged in displays

* Ad Campaign: only record plays on the campaign if the stat is for a layout. xibosignage/xibo#2971
@dagonix
Add translation strings for the dropdown list items
0ca5024
dasgarner
dasgarner requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that works because you're using a {% inside an existing {% and they shouldn't be nested.

What you can do instead is use a | syntax, so "Off"|trans

I hope that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasgarner dasgarner dasgarner requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagonix @dasgarner @ifarzana