Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added threadsafe to skin and noskin signature files #34

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Jun 21, 2022

I added the threadsafeuser statement to both signature files. This blocks using the callback function, but since we did not have success with the error messages until now, I hope that this will improve the performance a bit as implied by @rabernat

@jbusecke
Copy link
Contributor Author

I just tested this PR locally and got some really encouraging results:

This is a soft scaling experiment on my local machine:
image
Up to 4 threads the relative execution time remains very close to 1! Afterwards it increases almost linearly, which makes sense since my laptop has 4 cores (there are some low energy cores, but I am unsure if these are recruited for stuff like this).

@jbusecke
Copy link
Contributor Author

Ill merge this now and release, so we can hopefully use this for tomorrows session.

@jbusecke jbusecke merged commit 2c0c68c into xgcm:main Jun 22, 2022
@jbusecke jbusecke mentioned this pull request Jun 23, 2022
jbusecke added a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant