Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting complex polygons/ #225

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Conversation

pierot
Copy link

@pierot pierot commented Jun 14, 2018

For the issue and discussion see #224

@coveralls
Copy link

coveralls commented Jun 14, 2018

Coverage Status

Coverage decreased (-5.6%) to 77.918% when pulling f438518 on jackjoe:master into 5f4aa50 on xerions:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 68.613% when pulling 4a4702a on jackjoe:master into 0583579 on xerions:master.

@@ -369,6 +369,9 @@ defmodule Mariaex.RowParser do
defp decode_geometry(<<_len::8-little, srid::32-little, 1::8-little, 3::32-little, num_rings::32-little, rest::bits >>, fields, null_bitfield, acc, datetime, json_library) do
decode_rings(rest, num_rings, {srid, fields, null_bitfield, acc}, datetime, json_library)
end
defp decode_geometry(<<_len::8-little, _var_a::8-little, _var_b::8-little, srid::32-little, 1::8-little, 3::32-little, num_rings::32-little, rest::bits>>, fields, null_bitfield, acc, datetime, json_library) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the _var_a and _var_b values? Are we able to match on these more?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to match and maybe do something useful with it, but I have no clue what they are or what they contain. If someone can shed some light on this, I would be happy to adapt the code.

pierot and others added 25 commits September 25, 2018 09:54
* xerions-master: (23 commits)
  Update DBConnection git ref
  Update mariaex.ex
  Add Mariaex.prepare_execute
  Remove outdated pool config
  Update dbconnection reference
  Update types
  Fix return types
  Update docs
  Update to latest DBConnection
  Update to latest DBCOnnection
  Update to DBConnection 2.0
  Raise DBConnection.ConnectionError on connection error
  Add max rows option to each cursor fetch
  Remove reserved query name errors
  Support explicit cursor API
  Use one text statement for all queries
  Use database transaction status to prevent transaction errors
  Update decimal
  Remove Docker dependent test
  Fix typespec and README for rows as lists not tuples
  ...
* upstream/master:
  Release v0.9.1 with timestamp as DateTime (in UTC)
  Release v0.9.0
  Revert (for the prepared statements) irrelevant changes
  Use `""` as query name when prepare == :unnamed
  Remove unnecessary query sanitization
  Only sanitize query in the protocol module
  Add option `prepare` to overrule named prepare statements
  Improve test database setup
  Ignore .DS_Store
  Fix unused variable warnings
  Release 0.9.0-rc.0
  Update to DBConnection 2.0-rc
  fix .travis.yml for MySQL 8.0 image This image can't load caching_sha2_password.so
  fix not applying :timeout in query options
  add auth plugin mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants