Prevent viewer getSnapshot to add canvas on document #1107
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add a breaking change in the
viewer.getSnapshot()
API. I use theviewer
with a distance measurement plugin with a specified container that is notdocument.body
. But since this change, when a get a snapshot of the viewer, a canvas is also added on thedocument.body
. I propose to add acapture
parameter ongetShapshot
to prevent this behaviour if not requested (must be set totrue
if capturedcanvas
are desired).