Merge pull request #1661 from xeokit/XEOK-111-prevent-LASLoaderPlugin…

…-infinite-loop XEOK-111 Prevent LASLoaderPlugin infinite loop
xeokit · Sep 9, 2024 · fef2b27 · fef2b27
2 parents 10c97cb + 4b94859
commit fef2b27
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/plugins/LASLoaderPlugin/LASLoaderPlugin.js b/src/plugins/LASLoaderPlugin/LASLoaderPlugin.js
@@ -339,6 +339,7 @@ class LASLoaderPlugin extends Plugin {
         }
 
         const sceneModel = new SceneModel(this.viewer.scene, utils.apply(params, {
+            maxGeometryBatchSize: MAX_VERTICES,
             isModel: true
         }));
 

diff --git a/src/viewer/scene/model/vbo/batching/points/VBOBatchingPointsLayer.js b/src/viewer/scene/model/vbo/batching/points/VBOBatchingPointsLayer.js
@@ -45,7 +45,7 @@ export class VBOBatchingPointsLayer {
 
         this._renderers = getRenderers(cfg.model.scene);
 
-        const maxGeometryBatchSize = Math.min(5000000, cfg.maxGeometryBatchSize || window.Infinity);
+        const maxGeometryBatchSize = cfg.maxGeometryBatchSize || 5000000;
 
         const attribute = function() {
             const portions = [ ];
@@ -161,7 +161,7 @@ export class VBOBatchingPointsLayer {
         if (this._finalized) {
             throw "Already finalized";
         }
-        return (this._buffer.vertsIndex + (lenPositions / 3)) < this._buffer.maxVerts;
+        return (this._buffer.vertsIndex + (lenPositions / 3)) <= this._buffer.maxVerts;
     }
 
     /**