Skip to content

Commit

Permalink
Factor LOD into a centralized manager
Browse files Browse the repository at this point in the history
  • Loading branch information
xeolabs committed Jul 10, 2023
1 parent b7d4395 commit d49b903
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/plugins/XKTLoaderPlugin/XKTLoaderPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ class XKTLoaderPlugin extends Plugin {
* all geometry instances into batches (````false````), and not use instancing to render them. Setting this ````false```` can significantly
* improve Viewer performance for models that have excessive geometry reuse, but may also increases the amount of
* browser and GPU memory used by the model. See [#769](https://github.com/xeokit/xeokit-sdk/issues/769) for more info.
* @param {Boolean} [params.useDataTextures=false] When we set this ````true````, an alternative memory representation of object geometry will be used that relies on data textures. At the expense of some rendering performance overhead, this will reduce the used RAM to around 25% respect to setting the option to ````false````.
* @param {Boolean} [params.useDataTextures=false] Set ````true```` to use a {@link DataTextureSceneModel} to represent the returned model.
* @returns {Entity} Entity representing the model, which will have {@link Entity#isModel} set ````true```` and will be registered by {@link Entity#id} in {@link Scene#models}.
*/
load(params = {}) {
Expand All @@ -741,8 +741,6 @@ class XKTLoaderPlugin extends Plugin {
sceneModel = new DataTextureSceneModel(this.viewer.scene, utils.apply(params, {
isModel: true,
origin: params.origin,
targetLodFps: params.useDataTextures.targetLodFps || false,
enableViewFrustumCulling: params.useDataTextures.enableViewFrustumCulling || false,
disableVertexWelding: params.useDataTextures.disableVertexWelding || false,
disableIndexRebucketing: params.useDataTextures.disableIndexRebucketing || false,
}));
Expand Down

0 comments on commit d49b903

Please sign in to comment.