CA-386317: Add localization support for data-source descriptions #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code - Make `friendlyName` a public filed, and update `ToString()` to use it - Update constructor to take a description string - Improve variable naming - Remove `FriendlyName` from `DataPlot` and instead use helper method to fetch friendly names Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]>
CitrixChris
requested changes
Dec 4, 2023
| switch (originalId) | ||
| { | ||
| case "memory_free_kib": | ||
| return "memory_used_kib"; |
There was a problem hiding this comment.
I think these are the wrong way around
There was a problem hiding this comment.
The original was performing the same overrides, unless I'm missing something :/
memory_free_kib 👉 memory_used_kib
memory_internal_free 👉 memory_internal_used
if (dataSource.name_label == "memory_free_kib" && xenObject is Host)
friendlyName = Helpers.GetFriendlyDataSourceName("memory_used_kib", xenObject);
else if (dataSource.name_label == "memory_internal_free" && xenObject is VM)
friendlyName = Helpers.GetFriendlyDataSourceName("memory_internal_used", xenObject);
else
friendlyName = Helpers.GetFriendlyDataSourceName(dataSource.name_label, xenObject);and
if (datasourceName == "memory_free_kib")
FriendlyName = Helpers.GetFriendlyDataSourceName("memory_used_kib", xo);
else if (datasourceName == "memory_internal_free")
FriendlyName = Helpers.GetFriendlyDataSourceName("memory_internal_used", xo);
else
FriendlyName = Helpers.GetFriendlyDataSourceName(datasourceName, xo);
CitrixChris
added
needs updating
danilo-delbusso
added
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains cleanup. In general, I tried to only have one method to override data source names, so it's in
Helpers.