CA-379971: Ensure ParallelAction is not waiting on _lock when no actions are running
#3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actions are running There is a chance that all actions have completed before we hit the `Wait` call, we need to make sure we don't hit a deadlock. This can happen if for instance there is only one action, and it is a "dummy" action, such as the one used in the EUA check. Also I have removed the compound assignment for the `volatile _completedActionsCount` since Visual Studio was flagging it as a "suspicious usage of a volatile variable". I personally don't think it's a problem but better safe than sorry. Contains minor whitespace fixes, too Signed-off-by: Danilo Del Busso <[email protected]>
kc284
reviewed
Oct 25, 2023
kc284
approved these changes
Oct 25, 2023
CitrixChris
approved these changes
Oct 26, 2023
CitrixChris
added
2 approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One could also fix this by not running actions as soon as the
EnqueueActionis called (or maybe callingMonitor.Waitbefore the actions have started), but I didn't want to touch a lot of this code and potentially add new issues.The issue we're fixing here is that there is a chance that all actions have completed before we hit the
Waitcall, we need to make sure we don't hit a deadlock.This can happen if for instance there is only one action, and it is a "dummy" action, such as the one used in the EUA check.
Also I have removed the compound assignment for the
volatile _completedActionsCountsince Visual Studio was flagging it as a "suspicious usage of a volatile variable". I personally don't think it's a problem but better safe than sorry.Contains minor whitespace fixes, too