CA-382850: Catch exception when listing pipe names with invalid characters #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CitrixChris
requested changes
Sep 11, 2023
…cters Pipes can be created with invalid characters in their names (such as `|`). This results in an exception being thrown when those files are accessed via standard API calls such as `Directory.GetFiles`. Other processes might create these pipes and inadvertently prevent XenCenter from starting altogether. Signed-off-by: Danilo Del Busso <[email protected]>
danilo-delbusso
force-pushed
the
bug/pipe-file_CA-382850
branch
from
d98136a
to
099e220
Compare
kc284
reviewed
Sep 22, 2023
kc284
approved these changes
Sep 22, 2023
CitrixChris
approved these changes
Sep 22, 2023
CitrixChris
added
2 approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipes can be created with invalid characters in their names (such as
|). This results in an exception being thrown when those files are accessed via standard API calls such asDirectory.GetFiles. Other processes might create these pipes and inadvertently prevent XenCenter from starting altogether.