-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added patch to build.sh to fix missing go-vnc, updated README #50
Conversation
dongyuzheng
commented
Aug 31, 2016
•
edited
Loading
edited
- Added patch to build.sh to fix missing go-vnc
- Updated README
- Changing Golang version dependency to >= 1.6; < 2.0 because packer asks for 1.6 and Golang 1 has a compatibility promise
- Fixed cannot find package "github.com/xenserver/packer-builder-xenserver/builder/xenserver/iso" in any of: #45
…g has a backwards compability promise (https://golang.org/doc/go1compat), so >= is safe
@rdobson , are there any problems with my PR? |
@@ -15,6 +15,9 @@ rm -rf pkg/* | |||
rm -rf $GOPATH/pkg/* | |||
mkdir -p bin/ | |||
|
|||
# Fix for build failing due to missing go-vnc | |||
(cd $GOPATH/src/github.com/mitchellh && if cd go-vnc; then git pull; else git clone https://github.com/mitchellh/go-vnc.git; fi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this is required? the repo should be able to be vendored like the rest. Did you try this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I followed exactly:
- https://github.com/mitchellh/packer/blob/master/CONTRIBUTING.md#setting-up-go-to-work-on-packer
- https://github.com/xenserver/packer-builder-xenserver/blob/master/README.md#compile-the-plugin
Perhaps I should change this to something like go get go-vnc
, but either way, go-vnc
is never downloaded in either process. It's happened to both me and another guy: #45
ASIDE:
I've been working with packer-builder-xenserver for Windows and I've noticed the following problems:
- WinRM timeout is defaulted to 0s (expecting 20 minutes) WinRM timeout defaults to zero #52
- ssh_username is still required (should be winrm_username)
- plugin does not correctly get winrm host ip WinRM communicator uses wrong host and port #53
- plugin does not correctly set winrm port, and specifying winrm_port in the config is ignored WinRM communicator uses wrong host and port #53
I've made some patches for 3 and 4 to make it work in the meanwhile, but please take a look. I didn't make a PR because they're too hackish.