Commits on Aug 1, 2024

1. Enhance tracing to hunt for restore bug …

   The particular issue turned out to be that the nested UEFI host being
   restored had several disks attached.  Since this is done as NVMe namespaces
   of a single disk, all sharing the same ID, udev in dom0 does not have
   enough info and messes up /dev/disk/by-id/ on which restore relies because
   of /etc/xensource-inventory:
   
    lrwxrwxrwx 1 root root 13 Jul 15 14:28 nvme-QEMU_NVMe_Ctrl_nvme0 -> ../../nvme0n3
    lrwxrwxrwx 1 root root 15 Jul 15 14:28 nvme-QEMU_NVMe_Ctrl_nvme0-part1 -> ../../nvme0n2p1
    lrwxrwxrwx 1 root root 15 Jul 15 14:28 nvme-QEMU_NVMe_Ctrl_nvme0-part2 -> ../../nvme0n1p2
   
   Only the addition of the `tool.dump()` call allowed me to connect the
   "Failed to create root filesystem" error with that longstanding (in)famous
   issue, but a few other additions were useful to get there.
   
   Signed-off-by: Yann Dirson <[email protected]>
   (cherry picked from commit 02d72e6, with
   one additional safety guard that does not apply to master any more)

   

   ydirson committed Aug 1, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for fd1a6ee
   • Browse repository at this point

   Copy the full SHA

   fd1a6ee View commit details

   Browse the repository at this point in the history