Skip to content

Commit

Permalink
Remove 'unicode-builtin' from the pylint --py3k TODO list
Browse files Browse the repository at this point in the history
Signed-off-by: Bernhard Kaindl <[email protected]>
  • Loading branch information
bernhardkaindl committed Dec 7, 2023
1 parent 7580384 commit c5ed52e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:

# FIXME/TODO: These checks by pylint --py3k are currently failing:
py3_todo: "\
unicode-builtin,\
comprehension-escape,\
dict-keys-not-iterating,\
old-division"
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ Join the XSConsole community by creating issues in the repository to report bugs
- **As per this agreement**, until that point, changes supporting **only Python3.6+** must go to a **py3 feature branch**.
- The list of `TODOs` remaining for the Python3 upgrade checks (`pylint --py3k`) to be fulfilled is at [line 40 of `.github/workflows/main.yml`](https://github.com/xenserver-next/xsconsole/blob/master/.github/workflows/main.yml#L40).
Currently, the list of `pylint --py3k` `TODOs` is:
- `unicode-builtin` (a PR using a function for Py2 and Py3 is working and is coming next)
- `comprehension-escape`
- `dict-keys-not-iterating`
- `old-division`

0 comments on commit c5ed52e

Please sign in to comment.