builders: Added escape of 'env' parameter #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @lorc, could you, please, have a look? |
lorc
reviewed
Oct 23, 2023
Mishytca
force-pushed
the
dev/mykhailo-androsiuk
branch
from
e8b746f
to
6a92251
Compare
lorc
requested changes
Oct 24, 2023
Mishytca
force-pushed
the
dev/mykhailo-androsiuk
branch
from
6a92251
to
c69880b
Compare
lorc
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Thank you
Reviewed-by: Volodymyr Babchuk <[email protected]>
added 2 commits
October 25, 2023 17:58
There is an issue with passing the "EXT_MODULES" parameter from the configuration moulin yaml file to the build.sh context. The 'android_kernel' builder didn't escape double quotes, while wrapping the 'env' parameter in additional double quotes like this: bash -c "...env..." As a result, an incorrect syntax was generated in the build.ninja file. To generate a functional build.ninja file, it was necessary to take this aspect into account in the moulin.yaml file and add additional escaping there. This approach is ambiguous since it requires the user to know the implementation details of each moulin builder. To address this issue, a simple escape function was added to all builders that support the 'env' parameter. It escapes double quotes to ensure proper handling of the 'env' variable. The issue has been resolved for the following builders: - android_kernel builder - android builder - zephyr builder Signed-off-by: Mykhailo Androsiuk <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
The existing source code has failed to pass the Flake8 check in build_conf.py: Do not compare types, use 'isinstance()' (E721) That blocks merge of the other changes. This patch is intended to fix the above-mentioned lint warning. Signed-off-by: Mykhailo Androsiuk <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
Mishytca
force-pushed
the
dev/mykhailo-androsiuk
branch
from
c69880b
to
cb3b3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with passing the "EXT_MODULES" parameter from the configuration moulin yaml file to the build.sh context.
The 'android_kernel' builder didn't escape double quotes, while wrapping the 'env' parameter in additional double quotes like this:
bash -c "...env..."
As a result, an incorrect syntax was generated in the build.ninja file.
To generate a functional build.ninja file, it was necessary to take this aspect into account in the moulin.yaml file and add additional escaping there.
This approach is ambiguous since it requires the user to know the implementation details of each moulin builder.
To address this issue, a simple escape function was added to all builders that support the 'env' parameter. It escapes double quotes to ensure proper handling of the 'env' variable.
The issue has been resolved for the following builders: