Add tests for yaml_wrapper #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deedone
force-pushed
the
fix_list
branch
3 times, most recently
from
7723966
to
e97c5fe
Compare
Deedone
changed the title
Deedone
changed the title
lorc
reviewed
Mar 5, 2024
lorc
approved these changes
Mar 5, 2024
Currently moulin crashes when it tries to check if the default value is a list. Add support for storing lists to the _YamlDefaultValue. Signed-off-by: Mykyta Poturai <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
as_float func was checking for int type, probably due to copy-paste error. This patch fixes the type check to float. Signed-off-by: Mykyta Poturai <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
The error messages for the _YamlDefaultValue class are not consistent with the YamlValue class. Make them more similar where possible. Signed-off-by: Mykyta Poturai <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
Writing unit tests uncovered two bugs in the setitem method of the YamlValue class. 1. The method was raising exceptions with valid inputs. 2. Due to caching in yaml module, the new value was not being set. This commit fixes both issues by: 1. Hiding the exception raising code behind an else statement. 2. Replace the whole node, instead of trying to update it. replace_value method was removed, as it was no longer needed. Private _represent_value method was added to unify scalar node creation. Signed-off-by: Mykyta Poturai <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
Adding dict support to _YamlDefaultValue class will fully unify it with the YamlValue class. This will allow to safely use default nodes in place of the real ones. Signed-off-by: Mykyta Poturai <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
This patch adds tests for Yaml wrapper. It tests the following methods in YamlValue and _YamlDefaultValue classes: - as_str - as_int - as_float - as_bool - is_list - keys - items - get - __getitem__ - __setitem__ - __len__ - __iter__ Signed-off-by: Mykyta Poturai <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests that ensure that YamlValue and YamlDefaultValue provide the same API, and that the API is working. Fix the bugs that came up during testing.