Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

domd: Allow overwrite KERNEL_DEVICETREE variable #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

varder
Copy link

@varder varder commented Aug 18, 2021

KERNEL_DEVICETREE variable is used to generate the symbolic link for
the current domain. According to the current code the link will point
to the file which is at the end of the list of the variable.
But when a user specifies a device tree for a specific machine the
the link will still be pointing to the generic one.

Signed-off-by: Valerii Chubar [email protected]

KERNEL_DEVICETREE variable is used to generate the symbolic link for
the current domain. According to the current code the link will point
to the file which is at the end of the list of the variable.
But when a user specifies a device tree for a specific machine the
the link will still be pointing to the generic one.

Signed-off-by: Valerii Chubar <[email protected]>
@rshym
Copy link
Contributor

rshym commented Sep 3, 2021

Another possible solution for this issue - user can prepend his (her) DTB to KERNEL_DEVICETREE.

@rshym
Copy link
Contributor

rshym commented Sep 3, 2021

This PR revealed three issues with the modified receipt.

  1. We add DTB for all guests (doma and domu) in all products - maybe this needs to be fixed.
  2. We use double dash -- inside the name of DTB (salvator-generic-domu--5.10.0+git0*.dtb). Is it intentionally or just a misprint?
  3. Maybe we need to put a comment in this receipt, with an explanation of how to provide custom DTB? I mean that it needs to be prepended or appended. Just for the future.

@rshym
Copy link
Contributor

rshym commented Sep 3, 2021

Sorry, these issues are not addressed to the author of PR.

@rshym
Copy link
Contributor

rshym commented Sep 3, 2021

Seems that this PR may be merged but it needs comment in sources like this

# If you need to add custom DTB for a guest domain, then use KERNEL_DEVICETREE_append
# to overwrite generic guest file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants