UI: Add games directory and allow switching of games via controller in popup-menu #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schulle334
approved these changes
Apr 11, 2024
mborgerson
requested changes
May 6, 2024
mborgerson
force-pushed
the
add-games-directory
branch
from
9971fe5
to
1104ad0
Compare
|
Thanks for addressing the review feedback. I've rebased onto the latest version of the |
mborgerson
force-pushed
the
add-games-directory
branch
from
1104ad0
to
c889f91
Compare
… filesystem on draw loop, games within menu use disk icon instead of game pad
mborgerson
force-pushed
the
add-games-directory
branch
from
c889f91
to
209f1e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, switching between games in Xemu typically requires using a mouse/keyboard. When using a game controller, it's possible to open the popup menu, and select "Load Disc...", however that launches a native file browser which does not have controller input support, requiring use of a mouse/keyboard to select the target file. The goal of this PR is to make switching between games a bit more convenient and possible using a controller.
This PR introduces a new setting called "Games directory" within Settings > General > Miscellaneous. By default there is no value specified, and when clicked the user is presented with a file browser to select the desired directory containing .iso game files.
When the popup menu is activated (via right click, or start/back from an Xbox Controller S), there is now a "Games" submenu button that when selected, will present the user with a sorted list of games based on the configured directory. Selecting a game will result in Xemu loading the corresponding disc file. In the event no .iso files are detected in the directory, or if the directory is still undefined, there is an option "No games found" that when selected will open the main settings UI so that the user may adjust the games directory as needed.