Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed handling of PLY with vertex colors as uchar #1441

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed handling of PLY with vertex colors as uchar #1441

wants to merge 5 commits into from

Commits on Nov 17, 2023

  1. Fixed handling of PLY with vertex colors as uchar

    Eran Guendelman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d822b7e View commit details
    Browse the repository at this point in the history

  2. rotated sphere to make vertex colors clearer

    Eran Guendelman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    487c522 View commit details
    Browse the repository at this point in the history

  3. Changed PLY integer normalization to match Blender 

    Matching the normalization of integral types to what Blender does. e.g. int8 is divided by 127, uint8 is divided by 255, etc.

https://github.com/blender/blender/blob/01a2bd03695f217616acc2581fe8746f5cd226d7/source/blender/io/ply/importer/ply_import_data.cc#L104
https://github.com/blender/blender/blob/01a2bd03695f217616acc2581fe8746f5cd226d7/source/blender/io/ply/intern/ply_data.hh#L16
    Eran Guendelman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e2b018a View commit details
    Browse the repository at this point in the history

  4. update comment

    Eran Guendelman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    07463ae View commit details
    Browse the repository at this point in the history

  5. update comment

    Eran Guendelman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e9cb291 View commit details
    Browse the repository at this point in the history