Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes #29

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Assorted fixes #29

merged 7 commits into from
Nov 13, 2023

Commits on Nov 10, 2023

  1. build.sh: fix array expansion 

    Calling echo on expanded results only serves to negate the advantage of
using an array, as it will split any array element on whitespace.

Signed-off-by: Yann Dirson <[email protected]>
Cc: Simone Conti <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e6ed5e0 View commit details
    Browse the repository at this point in the history

  2. Dockerfiles: remove useless export as env-var 

    This is only used by this shell snippet.

Signed-off-by: Yann Dirson <[email protected]>
Cc: Simone Conti <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    af3b9cb View commit details
    Browse the repository at this point in the history

  3. Don't restrict cross-building to arm64 

    There's no apparent reason for such a restriction.  We'll need to revisit
anyway when XCP-ng supports other archs.  Just passing through the
--platform flag will likely be better.

Signed-off-by: Yann Dirson <[email protected]>
Cc: Simone Conti <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4a60584 View commit details
    Browse the repository at this point in the history

  4. README: use run.py not plain docker 

    Example predates the introduction of -v as run.py argument.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    82070fe View commit details
    Browse the repository at this point in the history

  5. build.sh: simplify parsing of release argument 

    We don't need any parsing beyond pattern matching, especially when given
parsing is brittle.

Signed-off-by: Yann Dirson <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    1b37ef1 View commit details
    Browse the repository at this point in the history

  6. Dockerfiles: fix checking existence of requested group 

    Besides that egrep is deprecated, the command was intended to be run
against /etc/groups, but acted on stdin.

getent is a much cleaner way to do the check anyway.

Signed-off-by: Yann Dirson <[email protected]>
Cc: Simone Conti <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2fe411b View commit details
    Browse the repository at this point in the history

  7. Dockerfiles: improve readability of user/group creation logic 

    Signed-off-by: Yann Dirson <[email protected]>
Cc: Simone Conti <[email protected]>
    @ydirson
    ydirson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d198d4a View commit details
    Browse the repository at this point in the history