Skip to content

Commit

Permalink
Merge branch 'optional-supplemental-packs' into next
Browse files Browse the repository at this point in the history
* optional-supplemental-packs:
  Hide supplemental-pack feature behind a feature flag
  • Loading branch information
ydirson committed Dec 23, 2022
2 parents 92642df + 20e66fc commit 6b79e04
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ def add_repos(main_repositories, update_repositories, repos, repo_gpgcheck, gpgc
for device in getRemovableDeviceList():
util.runCmd2(['eject', device])

if interactive:
if interactive and constants.HAS_SUPPLEMENTAL_PACKS:
# Add supp packs in a loop
while True:
media_ans = dict(answers_pristine)
Expand Down
1 change: 1 addition & 0 deletions constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,4 @@ def error_string(error, logname, with_hd):
FEATURES_DIR = "/etc/xensource/features"
HAS_RAID_ASSEMBLE = os.path.exists(os.path.join(FEATURES_DIR, "raid-assemble"))
HAS_RAID_CONFIGURE = os.path.exists(os.path.join(FEATURES_DIR, "raid-configure"))
HAS_SUPPLEMENTAL_PACKS = os.path.exists(os.path.join(FEATURES_DIR, "supplemental-packs"))
8 changes: 8 additions & 0 deletions doc/features.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,11 @@ Currently available feature flags are:

Offer user the ability to configure a software-RAID volume as
primary disk.

supplemental-packs

Support installation of supplemental packs after installation of
the main product.

This only impacts the UI, the <source> answerfile construct still
allows to include supplemental packs without this feature flag.

0 comments on commit 6b79e04

Please sign in to comment.