Rework wakeup of tcpJSONRPC #1182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move init of tcpJSONRPC to init of main iPad/iPhone controllers and do not start the heartbeat in the init anymore. Generally hook up starting the heartbeat timer with DidBecomeActive instead of WillEnterForeground as the socket will be available at this time and no additional timeout is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1175.
Move
initoftcpJSONRPCtoinitof main iPad/iPhone controllers and do not start the heartbeat in theinitanymore. Generally hook up starting the heartbeat timer withapplicationDidBecomeActiveinstead ofapplicationWillEnterForegroundas the socket will be available at this time and no additional timeout is needed.Summary for release notes
Improvement: Rework wakeup of tcpJSONRPC
Improvement: Avoid loss of connection during wakeup