This repository has been archived by the owner on Jun 4, 2023. It is now read-only.
Add dovi detection for mkv #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both parse/write implementations are based on mov/movenc. This only adds support for the "Dolby Vision configuration box". Other configuration boxes, such as "Dolby Vision enhancement layer configuration box" are not supported. The new functions will be used to implement parsing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid <[email protected]> Signed-off-by: Andreas Rheinhardt <[email protected]>
Adds handling of dvcC/dvvC block addition mappings. The parsing creates AVDOVIDecoderConfigurationRecord side data. The configuration block is written when muxing into Matroska, if DOVI side data is present for the track. Most of the Matroska element parsing is based on Plex's FFmpeg source code. Signed-off-by: quietvoid <[email protected]> Signed-off-by: Andreas Rheinhardt <[email protected]>
7 tasks
|
@fuzzard since we're probably not going to bump to ffmpeg 5 for Nexus, this looks like a pretty isolated change |
8 tasks
|
@thexai FYI: This PR + backported PR xbmc/xbmc#22423 to Nexus branch may allow Dolby Vision for MKV files in Nexus releases. Many people really want it. |
|
@the-black-eagle this PR misses mov.c and movenc.c files which also parse dolby isom. See https://github.com/FFmpeg/FFmpeg/search?q=dovi_isom.h |
|
In 4.4 mov has an independent implementation, it doesn't need |
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FFmpeg with two cherry-picked commits from FFmpeg master that allow detection of DolbyVision data in mkv files. Tested locally to ensure functionality. No changes in Kodi needed, current detection code works fine with this update.