Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and reorganize apply_ufunc material #180

Merged
merged 40 commits into from
Jun 28, 2023
Merged

Update and reorganize apply_ufunc material #180

merged 40 commits into from
Jun 28, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jun 14, 2023 •
edited
Loading

  • minimize data repr
  • Finish automatic vectorizing with numpy
  • Go through the interp end-to-end example
  • args, kwargs in simple numpy notebook
  • Break out numba guvectorize piece

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dcherian dcherian mentioned this pull request Jun 16, 2023
Closed
34 tasks
@dcherian dcherian mentioned this pull request Jun 21, 2023
Closed
@dcherian dcherian requested a review from scottyhq June 26, 2023 18:14
@dcherian dcherian marked this pull request as ready for review June 26, 2023 18:15
@dcherian
Copy link
Contributor Author

There's a bunch of material here. I'll think about a subset for the tutorial. Our plan was to have 30-40 minutes to explore, so there's plenty of material that attendees could look through.

@dcherian
Copy link
Contributor Author

Thanks! Just had a thought: should I move "Reductions and Core Dimensions" to a new "Core Dimensions" notebook? It's an important concept and could be nice to break out

@dcherian
Copy link
Contributor Author

should I move "Reductions and Core Dimensions" to a new "Core Dimensions" notebook?

Went ahead and did this. I like it!

scottyhq
scottyhq approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great set of notebooks @dcherian I feel like I have a much better understanding of how everything fits together :)

@dcherian
Copy link
Contributor Author

Thanks for the reading the whole thing Scott!

I pushed some major changes to the dask notebook to hopefully clarify the order of execution and wrapping.

@scottyhq
Copy link
Contributor

I pushed some major changes to the dask notebook to hopefully clarify the order of execution and wrapping.

Nice, it's all green now, I'd say go ahead and merge!

@dcherian dcherian merged commit 865c6e0 into xarray-contrib:main Jun 28, 2023
@dcherian dcherian deleted the apply-ufunc-reorg branch June 28, 2023 00:09
dcherian added a commit to dcherian/xarray-tutorial that referenced this pull request Jul 3, 2023
@dcherian
Merge remote-tracking branch 'upstream/main' into sidebar-update
22c0249 
* upstream/main:
  move custom accessors to advanced and add more complex, runnable examples (xarray-contrib#168)
  Update and reorganize apply_ufunc material (xarray-contrib#180)
  Add jupyterlab-myst 2.0 and sphinx-exercise (xarray-contrib#187)
  Add jupyterlab-myst (xarray-contrib#182)
  Add codespace config for scipy 2023 (xarray-contrib#184)
  Add SciPy  Instructions (xarray-contrib#183)
  Edits to "Xarray and Dask" (xarray-contrib#177)
  Setup PR Preview workflow (xarray-contrib#175)
  contents write permissions for github token (xarray-contrib#178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottyhq scottyhq scottyhq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @scottyhq