Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Player.Listener and update metadata #949

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Refactor Player.Listener and update metadata #949

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
379c161
Refactor Player.Listener and update metadata
ne0rrmatrix Aug 28, 2024
be15bd8
- Removed `remove-node` directive for `onCues` method.
ne0rrmatrix Aug 28, 2024
98da3c6
Remove incorrect `<attr>` an fix `Player.listener` to only remove the…
ne0rrmatrix Aug 28, 2024
5819be8
Merge branch 'main' into FixIPLayerListener
ne0rrmatrix Sep 2, 2024
454c543
Merge branch 'main' into FixIPLayerListener
moljac Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions source/androidx.media3/media3-common/Transforms/Metadata.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<metadata>
<metadata>
<attr
path="/api/package[@name='androidx.media3.common']/class[@name='StreamKey']/method[@name='compareTo' and count(parameter)=1 and parameter[1][@type='androidx.media3.common.StreamKey']]/parameter[1]"
name="managedType"
Expand Down Expand Up @@ -79,7 +79,10 @@
>
VideoGraphListenerOutputSizeChangedEventArgs
</attr>

<!-- Remove these as they cause issues with Media3.ExoPlayer-->
<remove-node
ne0rrmatrix marked this conversation as resolved.
Show resolved Hide resolved
path="/api/package[@name='androidx.media3.common']/interface[@name='Player.Listener']/method[@name='onPositionDiscontinuity' and count(parameter)=1 and parameter[1][@type='int']]"
/>
<!--
Trying to fix IExoPlayer issue, but adding this metadata causes the following error:

Expand Down