-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weight threshold option for temporal operations #683
Open
tomvothecoder
wants to merge
11
commits into
main
Choose a base branch
from
feature/531-temporal-apis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1546 1565 +19
=========================================
+ Hits 1546 1565 +19 ☔ View full report in Codecov by Sentry. |
9 tasks
tomvothecoder
commented
Aug 27, 2024
xcdat/utils.py
Outdated
Comment on lines
143
to
147
This function is useful for cases where the weighting of data might be | ||
skewed based on the availability of data. For example, if one season in a | ||
time series has more significantly more missing data than other seasons, it | ||
can result in inaccurate calculations of climatologies. Masking values that | ||
do not meet the minimum weight threshold ensures more accurate calculations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an accurate description?
tomvothecoder
commented
Aug 27, 2024
tomvothecoder
commented
Aug 27, 2024
- Add tests for threshold functions
- This method now masks data using the weights grouped properly, instead of using the `weight_var_with_weight_threshold()` function - Add `from __future__ import annotations` to `spatial.py` - Add and update units
tomvothecoder
force-pushed
the
feature/531-temporal-apis
branch
from
September 4, 2024 19:37
7e9635f
to
bd872cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
If applicable: