Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose plugins.local and themes.local via Docker volume #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skyr
Copy link

@Skyr Skyr commented Jul 25, 2017

Allow admins to install plugins and themes in a persistent manner (urgently required if you're automatically updating your Docker volumes via watchtower or similar) - mentioned in #9 :-)
Exposes two volumes; install and update process modified to keep original files from ttrss git repo to avoid conflicts during update.

@CorePoint
Copy link

Hey,
is there a reason this isn't merged yet? Would really like to add my own theme.

Greetings

@x86dev
Copy link
Owner

x86dev commented Nov 27, 2017

Seems like a very useful feature to me. However, I didn't find time to test this yet -- so the exposed volumes are purely optional, right? The patch looks sane to me ...

@Skyr
Copy link
Author

Skyr commented Nov 28, 2017

Yes. afaics ttrss will search plugins both in the plugins and the plugins.local directory (same goes for themes). So this won't interfere with your distributed plugins.
The volumes are optional; without a volume mapping, Docker should create unnamed volumes without any content (which can be deleted when disposing the container).

@psyciknz
Copy link

I wouldn't mind this being merged, I have need of the options-per-feed plugin and it'd be handy to expose the plugins volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants