Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved #162 #410

Closed
wants to merge 8 commits into from
Closed

Solved #162 #410

wants to merge 8 commits into from

Conversation

yashagarwal1999
Copy link
Contributor

Please describe your program and how to run it.
Solved Largest sum of consecutive numbers in an array in cpp #162
Call the function maxsum which will return a pair of integers when an array and its size is passed is passed
Solved Unique Array #323
Solved #78 in python
Pi Computation in One Line #78
...something... (replace this line)


What Programming Language?
C++,python
...language...

yashagarwal1999 and others added 8 commits October 19, 2019 12:43
Solved Largest sum of consecutive numbers in an array in cpp #162
Solved Valley Counting #96 in c++. If there are any changes let me know.
Solved   Unique Array #323 in python
Solved Pi Computation in One Line #78 in python
@yashagarwal1999
Copy link
Contributor Author

Also solved Counting Valley #96

@yashagarwal1999
Copy link
Contributor Author

I have added the files to their respective folders.

Copy link
Collaborator

@kannagikazuko kannagikazuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the file format username_filename_here.ext on all files. Also, if you could put the unique elem/array file in the /unique folder and pi one in approximate_pi, you should see the folders in a file browser.
As for approx pi, you can swap out def declaration with a lambda notation.

@wzhouwzhou wzhouwzhou added Change Requested Please see the reviewer(s)' comments for more information Lang: C++ Contributions made in C Plus Plus Lang: Python Contributions made in Python labels Oct 27, 2019
@wzhouwzhou
Copy link
Owner

Bump

@yashagarwal1999
Copy link
Contributor Author

I am closing this pull request as I have made these changes in #412 please check that thanks

@kannagikazuko kannagikazuko added wontfix/wontmerge This will not be worked on (probably because it is no longer relevant) invalid This doesn't seem right, perhaps it is spam... and removed Lang: C++ Contributions made in C Plus Plus Lang: Python Contributions made in Python Change Requested Please see the reviewer(s)' comments for more information labels Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right, perhaps it is spam... wontfix/wontmerge This will not be worked on (probably because it is no longer relevant)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants