alt #1
Merged
alt #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
oliver-sanders
approved these changes
Sep 20, 2023
cylc/rose/utilities.py
Outdated
| return _identify_templating_section(defined_sections) | ||
|
|
||
|
|
||
| def _identify_templating_section( |
There was a problem hiding this comment.
This shouldn't have an underscore prefix.
Underscore prefix means, don't use this outside of the scope it's defined in e.g:
- Underscore-prefixed method: only the class should use this
- Underscore-prefixed function: only the module should use this
- Underscore-prefixed module: only the package should use this
Co-authored-by: Oliver Sanders <[email protected]>
Co-authored-by: Oliver Sanders <[email protected]>
wxtim
commented
Sep 21, 2023
wxtim
commented
Sep 21, 2023
wxtim
merged commit 37ca72b
into
fix.template_section_name_for_defines
0 of 3 checks passed
wxtim
deleted the
fix.template_section_name_for_defines_with_refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.