account for jsonUrl being null in type signature #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this actually work? Not sure if gson will actually parse this correctly. |
|
I was concerned about that as well, I'll mock up a test for it later |
|
This doesn't work, I've opened an issue google/gson#2644 |
spacey-sooty
commented
Apr 21, 2024
Comment on lines
+19
to
+30
| @SuppressWarnings("unchecked") | ||
| @Override | ||
| public <T> TypeAdapter<T> create(Gson gson, TypeToken<T> type) { | ||
| Class<T> rawType = (Class<T>) type.getRawType().getClass(); | ||
| if (rawType != Optional.class) { | ||
| return null; | ||
| } | ||
| final ParameterizedType parameterizedType = (ParameterizedType) type.getType(); | ||
| final Type actualType = parameterizedType.getActualTypeArguments()[0]; | ||
| final TypeAdapter<?> adapter = gson.getAdapter(TypeToken.get(actualType)); | ||
| return new OptionalTypeAdapter(adapter); | ||
| } |
There was a problem hiding this comment.
This should allow us to parse Optional correctly but has a few warnings to do with unchecked casts
There was a problem hiding this comment.
I don’t think that is worth adding, for something we don’t really need anyway. Empty string is just fine and we can specify that.
There was a problem hiding this comment.
I'll open a new pr to default it to an empty string and close this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.