-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 'HTTP Image' demo to Python #62
Conversation
I didn't know of |
Workbench Library is our own rosetta stone :) |
For the record, I updated the other implementations as well. Also I made use of GLib default priority flag in the Python and Javascript implementations consistently with the other two implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
4 approvals. I guess it's time to merge. :-) |
I'm not sure whether that's the way you want to do async stuff in Python, but it works.
I wasn't happy with the hardcoded "200" in place of
Soup.Status.OK
, so I used the latter one. Let me know if there is a reason to prefer the hardcoded value.