Format Vala code #41
Merged
Format Vala code #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
requested review from
theCapypara,
Hofer-Julian and
lw64
as code owners
sonnyp
force-pushed
the
format-vala-code
branch
from
8680b50
to
c5afa53
Compare
sonnyp
commented
Dec 17, 2023
lw64
reviewed
Dec 17, 2023
Merged
sonnyp
commented
Dec 29, 2023
Comment on lines
+11
to
+20
| # Vala | ||
| # ./Workbench/build-aux/fun workbench-cli ci vala demos/**/*.vala | ||
| # Blueprint | ||
| find demos/ -type f -name "*blp" -print0 | xargs -0 ./build-aux/fun blueprint-compiler format | ||
| # ./Workbench/build-aux/fun workbench-cli ci blueprint demos/**/*.blp | ||
| # CSS | ||
| # ./Workbench/build-aux/fun workbench-cli ci css demos/**/*.css | ||
| # Rust | ||
| ./Workbench/build-aux/fun rustfmt --check --edition 2021 demos/**/*.rs | ||
| # Python | ||
| ./Workbench/build-aux/fun black --check demos/**/*.py |
There was a problem hiding this comment.
I commented those that do not pass yet.
I will fix the demos in a subsequent PR
workbench-cli already uncovered quite a few issues 🎉
There was a problem hiding this comment.
What does "do not pass" mean? Isn't all vala code formatted with the formatter, so linting should succeed, or is the linter or formater not 100% doing its job? (So that would mean fixing the linter/formater?)
There was a problem hiding this comment.
look at the code for the context of the comment
lw64
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using an "experimental" Workbench branch which exposes a CLI (sort of headless Workbench)
workbenchdev/Workbench#858
Formatted with