Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Port demos to TypeScript #201

Draft
wants to merge 97 commits into
base: main
Choose a base branch
from
Draft

Conversation

vixalien
Copy link

@vixalien vixalien commented Aug 12, 2024

This is my attempt to porting demos from javascript to workbench.

Groundwork

  • All files were renamed from .js to .ts. I will be running the TypeScript compiler (with tsc) to fix demo files as we go.
  • I added a simple README.typescript.md showing basic instructions on how I generated the types
  • I added a tsconfig.json file
  • I compiled and included all the types in workbench-types

Future tasks

Ported demos

  • About Dialog
  • Accessibility
  • Account ⚠️
  • Action Bar
  • Actions
  • Animation
  • Audio
  • Avatar ⚠️
  • Banner
  • Box
  • Boxed Lists
  • Breakpoints
  • Button Row
  • Button
  • CSS Gradients
  • Calendar
  • Camera ⚠️
  • Carousel
  • Checkboxes
  • Clamp
  • Color Dialog ⚠️
  • Color Picker ⚠️
  • Column View ⚠️
  • Context Menu
  • Custom Widget
  • Dialog
  • Drag and Drop ⚠️
  • Drawing Area ⚠️
  • Drop Down ⚠️
  • Drop Zone ⚠️
  • Email ⚠️
  • Emoji Chooser
  • Event Controllers
  • File Monitor ⚠️
  • Flow Box
  • Font Dialog ⚠️
  • Frame
  • Grid View
  • Grid
  • HTTP Image ⚠️
  • HTTP Request ⚠️
  • HTTP Server
  • Image
  • Label
  • Launcher ⚠️
  • Level Bars
  • Link Button
  • List Model
  • List View
  • Location ⚠️
  • Map
  • Memory Monitor
  • Menu Button
  • Menu
  • Message Dialogs ⚠️
  • Navigation View
  • Network Monitor
  • Notification
  • Open File ⚠️
  • Overlay Split View
  • Overlay
  • Picture
  • Popovers
  • Power Profile Monitor
  • Preferences Dialog
  • Progress Bar
  • Radio Buttons
  • Revealer
  • SVG
  • Save File ⚠️
  • Scale
  • Screencast ⚠️
  • Screenshot
  • Scrolled Window
  • Search
  • Select Folder ⚠️
  • Separator
  • Session Monitor and Inhibit ⚠️
  • Snapshot
  • Source View
  • Spell Checker
  • Spin Button
  • Spinner
  • Stack
  • Styling with CSS
  • Switch
  • Tab View
  • Text Colors
  • Text Fields
  • Text View
  • Toasts
  • Toggle Button
  • Tooltip
  • Video
  • View Switcher
  • Wallpaper ⚠️
  • Web View
  • WebSocket Client
  • Welcome

@vixalien
Copy link
Author

vixalien commented Aug 20, 2024

To work with this version of the demos while hacking on Workbench, you can bind mount it. For example,

sudo mount --bind /path/to/cloned/demos /path/to/Worbench

@vixalien
Copy link
Author

vixalien commented Sep 3, 2024

Currently all the demos are ported 🥳. However, some demos have // @ts-expect-error directives where the types generated have some issue or another. I have tried to create relevant issues upstream and link to them, but a longer term strategy may be need.

Now it's time for rebase, and working on other steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant