-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all deprecated actions + Related code #580
Conversation
Generated by 🚫 Danger |
697df96
to
c6dfa7b
Compare
Overall LGTM, but I'd love to have @spencertransier chime in and give the final PR review/approval especially wrt the removal of the |
I've been using this branch in Automattic/simplenote-android#1676 and so far so good 😄 |
@mokagio Sorry I missed this! I will review it this week. |
8ed2148
to
895d07b
Compare
@@ -2,7 +2,7 @@ module Fastlane | |||
module Actions | |||
class IosValidateCiBuildAction < Action | |||
def self.run(params) | |||
require_relative '../../helper/ios/ios_git_helper' | |||
return_value '../../helper/git_helper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended to be require_relative
instead of return_value
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through and verified that all the removed methods are not used anywhere but in Simplenote Android/iOS/Mac, which I know you're already working on updating. I just had a question about a require_relative
vs return_value
. Besides that, everything looks great. Approving to unblock.
lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_validate_ci_build.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Spencer Transier <[email protected]>
…mokagio/breaking-remove-deprecated-actions
…ove-deprecated-actions
What does it do?
They became obsolete with the introduction of the
Versioning
module in d050d84 (#512) and as discussed in #579 (review) we ought to move forward in deleting them and ship a new major version.Internal ref paaHJt-6gp-p2
Checklist before requesting a review
bundle exec rubocop
to test for code style violations and recommendationsspecs/*_spec.rb
) if applicablebundle exec rspec
to run the whole test suite and ensure all your tests passCHANGELOG.md
file to describe your changes under the appropriate existing###
subsection of the existing## Trunk
section.MIGRATION.md
file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.