Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all deprecated actions + Related code #580

Merged
merged 27 commits into from
Sep 3, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Aug 6, 2024

What does it do?

They became obsolete with the introduction of the Versioning module in d050d84 (#512) and as discussed in #579 (review) we ought to move forward in deleting them and ship a new major version.

Internal ref paaHJt-6gp-p2

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@dangermattic
Copy link
Collaborator

dangermattic commented Aug 6, 2024

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Base automatically changed from mokagio/only-support-version.properties to trunk August 7, 2024 00:59
@mokagio mokagio added this to the 1️⃣ Next Major Release milestone Aug 7, 2024
@mokagio mokagio marked this pull request as ready for review August 7, 2024 01:00
@mokagio mokagio force-pushed the mokagio/breaking-remove-deprecated-actions branch from 697df96 to c6dfa7b Compare August 7, 2024 01:29
@mokagio mokagio requested a review from a team August 7, 2024 01:44
@AliSoftware
Copy link
Contributor

Overall LGTM, but I'd love to have @spencertransier chime in and give the final PR review/approval especially wrt the removal of the lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb file, to confirm it's really not used anywhere in the release-toolkit codebase itself (e.g. by the Versioning module calling into it—I doubt it but better safe and double-check than sorry) or if it's used by any of our client repos, making sure that all the methods in here have a counterpart in the Versioning module they can be replaced with (I think they do, but again, better safe than sorry).

@mokagio
Copy link
Contributor Author

mokagio commented Aug 11, 2024

I've been using this branch in Automattic/simplenote-android#1676 and so far so good 😄

@spencertransier
Copy link
Contributor

@mokagio Sorry I missed this! I will review it this week.

Refer to a3978df and
651f3ce for the commits that
removed it.
@@ -2,7 +2,7 @@ module Fastlane
module Actions
class IosValidateCiBuildAction < Action
def self.run(params)
require_relative '../../helper/ios/ios_git_helper'
return_value '../../helper/git_helper'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended to be require_relative instead of return_value?

Copy link
Contributor

@spencertransier spencertransier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and verified that all the removed methods are not used anywhere but in Simplenote Android/iOS/Mac, which I know you're already working on updating. I just had a question about a require_relative vs return_value. Besides that, everything looks great. Approving to unblock.

This was referenced Sep 3, 2024
@mokagio mokagio merged commit 354e71d into trunk Sep 3, 2024
5 checks passed
@mokagio mokagio deleted the mokagio/breaking-remove-deprecated-actions branch September 3, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants