Skip to content

Commit

Permalink
Update prerelease parameter handling so that it doesn't change the …
Browse files Browse the repository at this point in the history
…pre-release property of the milestone if not specified
  • Loading branch information
iangmaia committed Sep 2, 2024
1 parent eb321aa commit c283c5e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def self.run(params)
url = github_helper.publish_release(
repository: repository,
name: name,
prerelease: prerelease
prerelease: prerelease == :unchanged ? nil : prerelease
)
UI.success("Successfully published GitHub Release #{name}. You can see it at '#{url}'")
url
Expand Down Expand Up @@ -49,7 +49,7 @@ def self.available_options
FastlaneCore::ConfigItem.new(key: :prerelease,
description: 'True if this should be published as a pre-release',
optional: true,
default_value: false,
default_value: :unchanged,
type: Boolean),
Fastlane::Helper::GithubHelper.github_token_config_item,
]
Expand Down
2 changes: 1 addition & 1 deletion spec/publish_github_release_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
allow(github_helper).to receive(:publish_release).with(
repository: test_repo,
name: test_name,
prerelease: false
prerelease: nil
).and_return('https://github.com/repo-test/project-test/releases/tag/1.0.0')

result = run_described_fastlane_action(
Expand Down

0 comments on commit c283c5e

Please sign in to comment.