Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency Analysis] Add Android Gradle Plugin #148

Merged
merged 5 commits into from
Jul 5, 2024
Merged

[Dependency Analysis] Add Android Gradle Plugin #148

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1892de
Build: Add dependency analysis plugin
ParaskP7 Jul 5, 2024
f22b759
Build: Ignored variants configuration for dependency analysis plugin
ParaskP7 Jul 5, 2024
bed6aeb
CI: Add a scheduled dependency analysis job
ParaskP7 Jul 5, 2024
c4c6803
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-Utils-A…
ParaskP7 Jul 5, 2024
7cdd059
Merge branch 'trunk' into build/dependency-analysis-android-gradle-pl…
ParaskP7 Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .buildkite/schedules/dependency-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
---

common_params:
# Common plugin settings to use with the `plugins` key.
- &common_plugins
- automattic/a8c-ci-toolkit#2.15.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the newest version?

Suggested change
- automattic/a8c-ci-toolkit#2.15.0
- automattic/a8c-ci-toolkit#3.4.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to do that @wzieba but I really don't want to make a change that can potentially block this PR (ie. failing CI, etc), me not knowing exactly what the diff between the 2 version are. 🤷

Can I maybe do that on a separate PR next week, and do that for all these 6 libraries I have been (Login, Media Picker) and will be touching next week (Aztec, About, Tracks)? 🙏

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What works best for you - the only breaking difference is related nvm installation, but if you prefer to do this in a separate PR, it's ok to me too 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great, I've noted this down and will create separate PRs for each library I have been or will be touching next week. 🗒️

the only breaking difference is related nvm installation

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @wzieba that this is now done: #150


agents:
queue: "android"

steps:
- label: "dependency analysis"
command: |
echo "--- 📊 Analyzing"
cp gradle.properties-example gradle.properties
./gradlew buildHealth
plugins: *common_plugins
artifact_paths:
- "build/reports/dependency-analysis/build-health-report.*"
notify:
- slack: "#android-core-notifs"
if: build.state == "failed"
2 changes: 2 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
plugins {
id "com.android.library" apply false
id "org.jetbrains.kotlin.android" apply false
id "com.autonomousapps.dependency-analysis"
}

allprojects {
Expand All @@ -22,6 +23,7 @@ allprojects {
}
tasks.withType(KotlinCompile).all {
kotlinOptions {
jvmTarget = JavaVersion.VERSION_1_8
allWarningsAsErrors = true
}
}
Expand Down
3 changes: 3 additions & 0 deletions gradle.properties-example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ android.useAndroidX=true
android.enableJetifier=false

android.nonTransitiveRClass=true

# Dependency Analysis Plugin
dependency.analysis.android.ignored.variants=release
4 changes: 3 additions & 1 deletion settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
pluginManagement {
gradle.ext.kotlinVersion = '1.6.10'
gradle.ext.kotlinVersion = '1.9.22'
gradle.ext.agpVersion = '8.1.0'
gradle.ext.automatticPublishToS3Version = '0.9.0'
gradle.ext.dependencyAnalysisVersion = '1.28.0'

plugins {
id "org.jetbrains.kotlin.android" version gradle.ext.kotlinVersion
id "com.android.library" version gradle.ext.agpVersion
id "com.automattic.android.publish-to-s3" version gradle.ext.automatticPublishToS3Version
id "com.autonomousapps.dependency-analysis" version gradle.ext.dependencyAnalysisVersion
}
repositories {
maven {
Expand Down
Loading