Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for radare2 #104

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add support for radare2 #104

wants to merge 7 commits into from

Conversation

trufae
Copy link

@trufae trufae commented Sep 18, 2024

This branch is rebased on top of the current master, but picks the code from #67, as well as the fixes introduced by @cryptax in #88 and extends the logic to also flag all the constant pool data, there are few more fixes to be done in r2 to get all the string references to work without depending on the blutter analysis.

Note that this PR also includes the build fix from #103 otherwise it was failing to compile.

I have also patches for the Dockerfile that i submitted half a year ago but as long as nothing was merged, i'm quite tempted to just contribute to the @AbhiTheModder fork instead.

@cryptax
Copy link

cryptax commented Sep 20, 2024

hey @worawit can you merge this in? lots of people use Radare2, not IDA Pro.
Thanks.

@trufae
Copy link
Author

trufae commented Sep 20, 2024

before merging i want to cleanup some code but having a feedback on this will would be good

Comment on lines +113 to +114
of << std::format("f app.base = {:#x}\n", app.base());
of << std::format("f app.heap_base = {:#x}\n", app.heap_base());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are un-necessary since they change with every run and aren't constant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but its good to have some as reference, but yeah i was trying to expose some pointers for later testing and see if those are useful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would be nice is to know where the object pool is located. aka the address of PP. because right now r2 bases it to address 0, but its configurable. and blutter can be specifying that address

@AbhiTheModder
Copy link
Contributor

@trufae thank you for adding the flag all the constant pool data it's a great help, @worawit please consider reviewing it once

@apkunpacker
Copy link

hey @worawit can you merge this pr? lots of people use Radare2, not IDA Pro. Including me and all termux users.
Thanks.

@trufae trufae force-pushed the test45 branch 3 times, most recently from 7855ea0 to 6c65845 Compare September 21, 2024 17:44
@trufae
Copy link
Author

trufae commented Sep 21, 2024

try again, should be good now

@AbhiTheModder

This comment was marked as resolved.

@trufae
Copy link
Author

trufae commented Sep 21, 2024

You are not using latest commit rebuild again pls

@AbhiTheModder
Copy link
Contributor

You are not using latest commit rebuild again pls

Ah, yes, thank you for pointing that out. I missed it, but after testing it now, it works perfectly. Awesome, thank you!

AbhiTheModder added a commit to AbhiTheModder/blutter-termux that referenced this pull request Sep 21, 2024
- by @truefae worawit#104
- revert base & heap_base comment
- needs latest r2 from git
@IndAlok
Copy link

IndAlok commented Sep 22, 2024

hey @worawit can you merge this pr? lots of people use Radare2, not IDA Pro. Including me and all termux users.
Thanks.

@trufae trufae changed the title WIP: Updated support for radare2 Updated support for radare2 Sep 24, 2024
@trufae
Copy link
Author

trufae commented Sep 24, 2024

Should be good to merge now

@trufae trufae changed the title Updated support for radare2 Add support for radare2 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants