WIP: isLoading: set true earlier, and false later #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdietze
commented
Nov 2, 2019
| isLoading() = false | ||
| } | ||
| case Failure(_) => | ||
| //TODO: send empty graph event? |
There was a problem hiding this comment.
when getNewGraph fails, I think we should clear the graph here.
There was a problem hiding this comment.
Suggested change
| //TODO: send empty graph event? | |
| eventProcessor.localEvents.onNext(ReplaceGraph(Graph.empty)).foreach { _ => | |
| isLoading() = false | |
| } |
fdietze
commented
Nov 2, 2019
| } | ||
| case Failure(_) => | ||
| //TODO: send empty graph event? | ||
| isLoading() = false |
There was a problem hiding this comment.
Suggested change
| isLoading() = false |
|
I think, this generally is probably "more correct", but also a bit error-prone because you have to reset isLoading in multiple places at the end. It is a bit difficult to read on the github web ui. Best thing would probably issuing a new-increasing sequence number for each request. then let rawgraph return the sequence number it belongs to. Then isLoading just becomes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.