Update swc_core to v0.100.x

[kdy1]

https://swc.rs/docs/plugin/selecting-swc-core

I found that mdxjs-rs was using a hack based on SyntaxContext, but it's not possible anymore and I'm not sure how should I fix it.

[wooorm]

Hey! Did this work for you locally? Are you still working on making CI green?

[kdy1]

I'm not sure how I should modify the hack using SyntaxContext, and that's why I filed this PR.

[wooorm]

what is the hack? 🤔

[kdy1]

I meant

mdxjs-rs/src/hast_util_to_swc.rs

Line 43 in e077220

pub const MAGIC_EXPLICIT_MARKER: u32 = 1337;

[kdy1]

Can you help remove the hack? The Span does not have SyntaxContext anymore, and if I ignoring explciit_jsx, the test fails

[kdy1]

Nevermind, I fixed it

[wooorm]

Nice! Does that mean you changed SWC to allow some magic number marking again?
I see this PR is still a draft, do let me know if I can help / if it’s ready!

[kdy1]

Instead of modifying swc back to allow magic number, I introduced FxHashSet<Span> that holds the spans of explicit JSX inputs. And now it's ready for a review. Thank you!

[wooorm]

ok, I looked into applying the same updates to markdown-rs too, which has some more parsing tests. Something changed in SWC to make a (correct) test fail there. Will have to investigate tomorrow why that is and what’s needed!

[wooorm]

It looks like when I pass " /* " to SWC, it now returns an error for Error { error: (1..1, Eof) }. I need to know that the error is at the end of the input. Seems the positional info of hi is incorrect? Could that be a regression?

[wooorm]

Can confirm that I got Error { error: (2..5#0, UnterminatedBlockComment) } before on 0.94.0. It broke in 0.95.0.

Is this something that can be fixed in SWC, that EOF errors “stick” to the end again?

[kdy1]

I can fix it in SWC. I'll do it tomorrow

[wooorm]

Great, thank you! 🙏

[kdy1]

@wooorm Do you have a PR for swc upgrade? I merged/published patch in swc-project/swc#9361 but I'm not sure if it's fixed.

[wooorm]

not seeing a release on https://crates.io/crates/swc_core/versions btw? 👀

[wooorm]

PR at wooorm/markdown-rs#120

[wooorm]

Released, thank you! https://github.com/wooorm/mdxjs-rs/releases/tag/0.2.6

[kdy1]

Thank you!