Implement repo agents #4150
Implement repo agents #4150
Conversation
6543
added
the
build_pr_images
|
Deploying preview to https://woodpecker-ci-woodpecker-pr-4150.surge.sh |
|
pull preview images should be published now, to be tested |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4150 +/- ##
==========================================
- Coverage 26.44% 26.38% -0.07%
==========================================
Files 376 377 +1
Lines 27455 27605 +150
==========================================
+ Hits 7260 7283 +23
- Misses 19530 19656 +126
- Partials 665 666 +1 ☔ View full report in Codecov by Sentry. |
| } // @name Agent | ||
|
|
||
| const ( | ||
| IDNotSet = -1 | ||
| agentFilterOrgID = "org-id" | ||
| IDNotSet = -1 |
There was a problem hiding this comment.
Can we put this var into a generic file?
There was a problem hiding this comment.
Not that I know, but it's a generic var. If it's called AgentIDNotSet or something similar it would fit here, but just IDNotSet is a generic name so it should be in a generic file.
There was a problem hiding this comment.
@anbraten what was the exact reasoning for the comst name suggestion?
There was a problem hiding this comment.
It was called SystemAgentOwnerID before which was misleading IMO. AgentIDNotSet would be fine as well.
|
What about my comment above?
|
There was a problem hiding this comment.
Would like to test and get feedback for org agents in addition with repo-id=... / repo=owner/name filter first with the 3.0 release as those filters should allow the exact same result while being more flexibel already. We should add some docs how org agents work in general and how they could be used with filters.
followup to #3539