Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two row layout for title and context of pipeline list #3976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jul 25, 2024

This PRs adds the two row layout for the pipeline list again to allow showing long messages and pr titles.

image

@anbraten anbraten added ui frontend related enhancement improve existing features labels Jul 25, 2024
@anbraten anbraten added this to the 3.0.0 milestone Jul 25, 2024
@zc-devs
Copy link
Contributor

zc-devs commented Jul 25, 2024

It turns out you're ahead of me, that is cool 👍
Could you add some branch-mark?
Add build-image label, please.

@qwerty287
Copy link
Contributor

Yes this looks better to me, thanks.

I agree with @zc-devs, PR/branch icons are missing.

Also I don't think we have a benefit from showing the PR title twice now. Can't this be done in the corresponding PR?

@xoxys
Copy link
Member

xoxys commented Aug 8, 2024

Does it work on the mobile view? Can you add an example screenshot for that as well?

@lafriks
Copy link
Contributor

lafriks commented Aug 9, 2024

Maybe we can we just show PR number before title in first row and in second only commit?

@qwerty287
Copy link
Contributor

Maybe we can we just show PR number before title in first row and in second only commit?

I wouldn't do this as later, we might have both PR title and commit title. Commit title should go into the first row, but PR title in the second one (see #3421)

@lafriks
Copy link
Contributor

lafriks commented Aug 11, 2024

I would probably do the other way around as the PR title is more likely to be more descriptive and is the primary info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants