Refactor stepbuilder #3967
Refactor stepbuilder #3967
Conversation
anbraten
changed the title
depends_on in cli & move stepbuilder
| @@ -33,32 +32,29 @@ import ( | |||
| "go.woodpecker-ci.org/woodpecker/v2/pipeline/frontend/yaml/linter" | |||
| "go.woodpecker-ci.org/woodpecker/v2/pipeline/frontend/yaml/matrix" | |||
| yaml_types "go.woodpecker-ci.org/woodpecker/v2/pipeline/frontend/yaml/types" | |||
| "go.woodpecker-ci.org/woodpecker/v2/server" | |||
| forge_types "go.woodpecker-ci.org/woodpecker/v2/server/forge/types" | |||
There was a problem hiding this comment.
As you might have seen in the code below: // TODO: use don't import from server => move FileMeta to pipeline package 😉
There was a problem hiding this comment.
Duplicating server models is again quite a pain. Maybe we should move the models to a central place as duplicating them as we did in woodpecker-go for example is making the code mainly harder to update and read
|
Deploying preview to https://woodpecker-ci-woodpecker-pr-3967.surge.sh |
anbraten
changed the title
depends_on in cli & move stepbuilder
| ) | ||
|
|
||
| type Item struct { | ||
| Workflow *model.Workflow // TODO: get rid of server type in this package |
There was a problem hiding this comment.
@6543 How should we handle this type? Should we move the server models to a shared package? Would like to avoid duplicating them somehow.
There was a problem hiding this comment.
No via DTOs that might to u like more boilerplate but it helps with portability in the long run
| Config *backend_types.Config | ||
| Yamls []*forge_types.FileMeta // TODO: get rid of server type in this package | ||
| CompilerOptions []compiler.Option | ||
| GetWorkflowMetadata func(*model.Workflow) metadata.Metadata |
There was a problem hiding this comment.
Somehow I find this prop name not clear, maybe name it WorkflowMetadataFunc?
|
Linter still fails :/ |
Support
depends_onin cli.Simplify how the
stepBuilderworks.