Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisting the dispute status when closed #3445

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Sep 19, 2024

Fixes 4465-gh-woocommerce/woocommerce-subscriptions

Changes proposed in this Pull Request:

This PR introduces a new meta that will persist the status of a dispute after it is closed. This will be useful for adequately changing a subscription status (as in the issue that raised this PR).

Testing instructions

Code review should be enough. Check if the tests are still passing. I have introduced specific tests for this change.

You can also test the dispute flow (a bit hard) and check if the new meta is present on the affected order.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Sep 19, 2024
@wjrosa wjrosa marked this pull request as ready for review September 19, 2024 22:32
@wjrosa wjrosa requested review from a team and Mayisha and removed request for a team September 19, 2024 22:32
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good @wjrosa. Thanks for adding the tests 👍

@wjrosa wjrosa merged commit 5010cc7 into develop Sep 20, 2024
34 of 35 checks passed
@wjrosa wjrosa deleted the tweak/persisting-dispute-status branch September 20, 2024 18:47
wjrosa added a commit that referenced this pull request Sep 23, 2024
wjrosa added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants