Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MAXQ 1065/1080 LWIP example. #462

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

anhu
Copy link
Member

@anhu anhu commented Sep 18, 2024

No description provided.

#else

#if defined (TEST_RSA)
ret = wolfSSL_CTX_use_PrivateKey_buffer(ctx, rsa_key_der_2048,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent for readability

maxq10xx/wolfssl-lwip-client.c Show resolved Hide resolved
/* Print to stdout any data the server sends */
MXC_DEBUG_MSG("Server: %s\n", buff);
return ret;
// ret = 0; /* success */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove double comment style here


if (sockfd >= 0)
lwip_close(sockfd);
while(lwip_read(sockfd,lBuff, SOCKET_BUF_SIZE) > 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this after the close of the socket? Is it to flush it after the socket has already been closed? Nit pick: there is no space after first ,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for feedback from someone else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the feedback received, this is correct. The socket is being flushed.

maxq10xx/wolfssl-lwip-client.c Show resolved Hide resolved

This example shows how to write a simple TLS client that uses the features
of the Analog Devices MAXQ1065 and 1080 USS. Note that this is not a
stand-alone application. This is part of an example that can be found in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...part of an example that can be found in the SDK supplied by Analog Devices.

Is this example our IP? Written by us. Please add how someone would go about compiling the example. i.e. if should download the SDK then add wolfssl-lwip-client.c to a specific location and build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not addressed yet. Waiting for feedback from someone else.

@JacobBarthelmeh JacobBarthelmeh assigned anhu and unassigned wolfSSL-Bot Sep 18, 2024
@anhu
Copy link
Member Author

anhu commented Sep 20, 2024

All issues except 2 have been addressed.

@JacobBarthelmeh JacobBarthelmeh merged commit f935fd0 into wolfSSL:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants