-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantizer v2 #26
Draft
aquaticsarah
wants to merge
16
commits into
wntrblm:main
Choose a base branch
from
aquaticsarah:quantizer-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Quantizer v2 #26
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for af36b74 - Browse repository at this point
Copy the full SHA af36b74View commit details -
firmware: Add pitch CV quantizer logic
Note: For now, the scale cannot be chosen. The input is always quantized to the nearest 12-tone equal temperament step.
Configuration menu - View commit details
-
Copy full SHA for 4b3db64 - Browse repository at this point
Copy the full SHA 4b3db64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa73df - Browse repository at this point
Copy the full SHA 0aa73dfView commit details -
User guide: Fix layout of quantizer settings description
The version of the description added in the previous patch was marked up wrong, resulting in the text appearing in two separate boxes rather than one box with two paragraphs inside it. This patch fixes that issue.
Configuration menu - View commit details
-
Copy full SHA for ef065cb - Browse repository at this point
Copy the full SHA ef065cbView commit details
Commits on Apr 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 53476a4 - Browse repository at this point
Copy the full SHA 53476a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d5a79 - Browse repository at this point
Copy the full SHA 28d5a79View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a0e6c - Browse repository at this point
Copy the full SHA a3a0e6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 818567a - Browse repository at this point
Copy the full SHA 818567aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 418aeb0 - Browse repository at this point
Copy the full SHA 418aeb0View commit details -
firmware: Implement sysex messages for handling quantizer configs
Note: For testing purposes, these sysexes currently affect the live config directly. A later commit will change them to affect the config in flash. As the config struct is about 2KB in size, and we end up needing ~2 copies on the stack in cmd_0x1A_read_quantizer_config_(), we need to increase the stack size to 8KB to prevent overflow. This can likely be reduced in future.
Configuration menu - View commit details
-
Copy full SHA for 779ead3 - Browse repository at this point
Copy the full SHA 779ead3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1de9709 - Browse repository at this point
Copy the full SHA 1de9709View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed8a395 - Browse repository at this point
Copy the full SHA ed8a395View commit details -
The previous commits needed more stack size than was previously allocated, and changed the STACK_SIZE variable in configure.py accordingly. Strangely, however, the linker still only allocated 2KB to the stack. On further investigation, the line STACK_SIZE = DEFINED(__stack_size__) ? __stack_size__ : 0x800; doesn't work, it always sets STACK_SIZE to 0x800. But changing it to STACK_SIZE = __stack_size__ works perfectly
Configuration menu - View commit details
-
Copy full SHA for e9df253 - Browse repository at this point
Copy the full SHA e9df253View commit details -
firmware: Allocate space for quantizer table in flash
It is important to ensure that the addresses and lengths of the existing NVM sections (settings and lut) are not changed by this patch. I have manually verified this as follows: * Build the firmware before applying this commit * Run: $ objdump -t build/gemini-firmware.elf | grep _nvm * Then apply the commit and rebuild * Run objdump again * Compare the two sets of outputs. The relevant columns are the first (symbol value) and last (symbol name)
Configuration menu - View commit details
-
Copy full SHA for b9e33f6 - Browse repository at this point
Copy the full SHA b9e33f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for da87201 - Browse repository at this point
Copy the full SHA da87201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 315d2d8 - Browse repository at this point
Copy the full SHA 315d2d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.