Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes browser to freeze when interacting with images in Google search #30

Open
kubrickfr opened this issue Jul 17, 2023 · 10 comments
Open

Comments

@kubrickfr
Copy link

As it has been reported many times on the add-on home page recently, whether it's something Google did or Mozilla, using this add-on makes Firefox "freeze" when tapping on images in Google search.

@Rob--W
Copy link
Collaborator

Rob--W commented Jul 17, 2023

I was able to reproduce this last week:

  1. Install the add-on, allow access to private browsing.
  2. Search for "Smiley"
  3. Tap on the image in the search regular results. Result: Google Search result page seems to freeze.

Additionally, I verified that the "freeze" is not a deadlock in Firefox or something. It looks like the Google Search result page itself intentionally refuses to scroll down.

@Rob--W
Copy link
Collaborator

Rob--W commented Jul 17, 2023

Someone also filed a bug with some details at https://bugzilla.mozilla.org/show_bug.cgi?id=1843106

@tesmite
Copy link

tesmite commented Jul 21, 2023

This happens because the Google Search page for mobile versions of Chrome (and Safari) does not work properly in Firefox.
To be precise, the preview window that appears after tapping an image is transparent in Firefox, which makes the search page look as if it is frozen.
This problem also occurs when User-Agent is spoofed by other methods than this add-on in all versions of Firefox including PC version.
It is unclear whether this is due to a bug in Firefox that prevents normal execution or whether Google's implementation deviates from the web standard and cannot be executed in Gecko.
In any case, it is necessary to implement a script in the add-on to modify the preview window so that it can be displayed correctly.

@saschanaz
Copy link

saschanaz commented Jul 21, 2023

One notable thing is that on Firefox there's aria-hidden=true on <c-wiz> but not on Chrome. Perhaps something fails to un-hide or such?

Edit: Another is that #Sva75c .dFMRD gets an inline style="opacity: 0; pointer-events: none;" only on Firefox.
Edit 2: dFMRD also gets aria-busy=true on Firefox but =false on Chrome. One may guess some rendering process failed in the middle of something.

@saschanaz
Copy link

I think this is at least partially Firefox bug.

  1. Click an image in https://www.google.com/search?q=%EC%9F%88%EB%9D%BC+%EB%AF%B8%EB%82%98%EC%BD%94
  2. Find .dFMRD (there's only one)
  3. Remove opacity: 0 (At this point still nothing is visible.)
  4. Try removing every attribute and children of that element and add some text node, so that it effectively becomes just <div>Foo</div>. Still nothing is visible
  5. Try editing that node with "Edit As HTML". Suddenly the element becomes visible

So the element just mysteriously gets stuck with invisible state that I cannot explain in CSS way.

@saschanaz
Copy link

Reopened https://bugzilla.mozilla.org/show_bug.cgi?id=1843106.

@PigDan20
Copy link

PigDan20 commented Aug 3, 2023

Love and appreciate the add-on since the start of using Firefox.

I'm having the same issue and several people in the extension's Mozilla Add-ons review section are reporting it as well. It seems it's gotten worse the last few months. Any news on a possible fix? The alternative of not using it is extremely user-unfriendly, as users know.. Google pushes the worst version of their search experience to Firefox users. It's frustrating having to turn the extension on and off several times a day -- refreshing doesn't work anymore, it's totally broken, both in the initial Google search results page & in the Google Images page.

It says the add-on hasn't been updated since Oct. 6th, 2020, so at first I wasn't sure if this was still being actively maintained (or needed regular updates). I'm sure a lot of Firefox users use this extension so I'm surprised it's apparently not affecting even more people cause they would've said something!

@Djfe
Copy link

Djfe commented Sep 8, 2023

shame Noone found the root cause yet.
Is there any way I could help?
Is anyone acfively working on this?

@Djfe
Copy link

Djfe commented Sep 8, 2023

oh, wait. it appears this got fixed somehow, maybe by Google?

@Rob--W
Copy link
Collaborator

Rob--W commented Sep 8, 2023

As commented at https://bugzilla.mozilla.org/show_bug.cgi?id=1843106#c30, I am still able to reproduce in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants