feat: Remove a group from conversation list after leaving it #18227
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18227 +/- ##
=======================================
Coverage 46.39% 46.40%
=======================================
Files 797 800 +3
Lines 25798 25833 +35
Branches 5886 5889 +3
=======================================
+ Hits 11970 11987 +17
- Misses 12326 12341 +15
- Partials 1502 1505 +3 |
e-maad
requested changes
Oct 29, 2024
| @@ -321,6 +321,25 @@ export class ActionsViewModel { | |||
| return Promise.reject(); | |||
| }; | |||
|
|
|||
| readonly removeConversation = (conversationEntity: Conversation): Promise<void> => { | |||
| if (conversationEntity.isGroup() && conversationEntity.isSelfUserRemoved()) { | |||
| return new Promise(() => { | |||
There was a problem hiding this comment.
Do we need to wrap it in promise?
| { | ||
| condition: conversationEntity.isGroup() && conversationEntity.isSelfUserRemoved(), | ||
| item: { | ||
| click: async () => actionsViewModel.removeConversation(conversationEntity), |
There was a problem hiding this comment.
After removing promise wrapper:
Suggested change
| click: async () => actionsViewModel.removeConversation(conversationEntity), | |
| click: () => actionsViewModel.removeConversation(conversationEntity), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possibility to remove a group conversation from list, while user has leave a group, or will be kicked from the group.
Checklist